-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go sdk relase upgrade #658
Go sdk relase upgrade #658
Conversation
@danijelTxFusion please run the format and spell checks locally to fix CI issues. Also please update the template with the details of the changes |
73a5528
to
fa0392f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some requests/suggestions.
In the future it would be good to reference code snippets to lines of code in repositories where there's a CI that asserts the code snippets work as intended (so ref to https://github.com/zksync-sdk/zksync2-examples and add a GH Action that asserts functionality there or otherwise add a directory in this repository that hosts script snippets code)
f16875c
to
a313f90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you Danijel.
a313f90
to
711b1a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions
ca98224
to
bee4f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bee4f6c
to
db718b7
Compare
db718b7
to
514e1ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Update the documentation for
v0.3.0
release of go SDK.