Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go sdk relase upgrade #658

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

danijelTxFusion
Copy link
Contributor

@danijelTxFusion danijelTxFusion commented Aug 4, 2023

Update the documentation for v0.3.0 release of go SDK.

docs/api/go/types.md Outdated Show resolved Hide resolved
@uF4No
Copy link
Contributor

uF4No commented Aug 4, 2023

@danijelTxFusion please run the format and spell checks locally to fix CI issues. Also please update the template with the details of the changes

@danijelTxFusion danijelTxFusion force-pushed the go-sdk-relase-upgrade branch 3 times, most recently from 73a5528 to fa0392f Compare August 6, 2023 02:59
@danijelTxFusion danijelTxFusion marked this pull request as ready for review August 6, 2023 03:01
@danijelTxFusion danijelTxFusion requested a review from a team as a code owner August 6, 2023 03:01
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requests/suggestions.

In the future it would be good to reference code snippets to lines of code in repositories where there's a CI that asserts the code snippets work as intended (so ref to https://github.com/zksync-sdk/zksync2-examples and add a GH Action that asserts functionality there or otherwise add a directory in this repository that hosts script snippets code)

docs/api/go/getting-started.md Show resolved Hide resolved
docs/api/go/examples/custom_paymaster/02_deploy_account.md Outdated Show resolved Hide resolved
docs/api/go/accounts.md Outdated Show resolved Hide resolved
docs/api/go/accounts.md Outdated Show resolved Hide resolved
docs/api/go/clients.md Show resolved Hide resolved
docs/api/go/contracts.md Show resolved Hide resolved
@danijelTxFusion danijelTxFusion force-pushed the go-sdk-relase-upgrade branch 3 times, most recently from f16875c to a313f90 Compare August 10, 2023 15:18
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Danijel.

Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

docs/api/go/examples/01_deposit.md Outdated Show resolved Hide resolved
docs/api/go/examples/06_create2.md Outdated Show resolved Hide resolved
docs/api/go/paymaster-utils.md Show resolved Hide resolved
docs/api/go/accounts.md Outdated Show resolved Hide resolved
@danijelTxFusion danijelTxFusion force-pushed the go-sdk-relase-upgrade branch 3 times, most recently from ca98224 to bee4f6c Compare August 14, 2023 23:46
idea404
idea404 previously approved these changes Aug 15, 2023
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idea404 idea404 disabled auto-merge August 17, 2023 10:45
@idea404 idea404 merged commit 4ff2857 into matter-labs:main Aug 17, 2023
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@danijelTxFusion danijelTxFusion deleted the go-sdk-relase-upgrade branch September 29, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants