Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds preview titles #669

Merged
merged 20 commits into from
Aug 22, 2023
Merged

feat: adds preview titles #669

merged 20 commits into from
Aug 22, 2023

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented Aug 17, 2023 •
edited
Loading

What 💻

  • Adds titles for twitter cards
  • fix previews title and desc for opengraph
  • Bonus: adds LayerZero to devtools page

Why ✋

  • Title and description in opengraph tags are hardcoded for all pages.

Evidence 📷

Before: sharing the Tools page generates this OG card. The title and description are not specific to the Tools page but the index page of the docs
Screenshot 2023-08-17 at 17 11 32

After:

Screenshot 2023-08-17 at 17 38 14

Notes 📝

I didn't manage to fix the description for twitter preview 🫤

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 762502e):

https://aqwzx-zksync-v2-docs--pr669-feat-devrl-243-14or335k.web.app

(expires Tue, 29 Aug 2023 10:34:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

@uF4No uF4No changed the title feat: adds OG plugin feat: adds preview titles Aug 18, 2023
@uF4No uF4No marked this pull request as ready for review August 18, 2023 16:08
@uF4No uF4No requested a review from a team as a code owner August 18, 2023 16:08
idea404
idea404 suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes related to grammar
Might merit looking later into grammar of wider docs

docs/dev/how-to/verify-contracts.md Outdated Show resolved Hide resolved
docs/api/README.md Outdated Show resolved Hide resolved
docs/api/api.md Outdated Show resolved Hide resolved
docs/api/go/README.md Outdated Show resolved Hide resolved
docs/api/go/accounts-l1-l2.md Outdated Show resolved Hide resolved
docs/tools/hardhat/plugins.md Outdated Show resolved Hide resolved
docs/tools/testing/README.md Outdated Show resolved Hide resolved
docs/tools/testing/dockerized-testing.md Outdated Show resolved Hide resolved
docs/tools/testing/era-test-node.md Outdated Show resolved Hide resolved
docs/tools/zksync-cli/README.md Outdated Show resolved Hide resolved
idea404
idea404 suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@idea404 idea404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes related to grammar
Might merit looking later into grammar of wider docs

@uF4No uF4No merged commit 952a2ca into main Aug 22, 2023
7 checks passed
@uF4No uF4No deleted the feat/DEVRL-243 branch August 22, 2023 12:36
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce left review comments

@idea404 idea404 idea404 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uF4No @MexicanAce @idea404