Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vyper verification warnings, rename plugin #687

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: add vyper verification warnings, rename plugin #687

merged 2 commits into from
Sep 5, 2023

Conversation

FilipTxFusion
Copy link
Contributor

What 💻

  • Renamed hardhat-zksync-vyper-verify to hardhat-zksync-verfiy-vyper
  • Added verification context warning for the verify-vyper plugin
  • Added alpha release warning for the verify-vyper plugin

Why ✋

  • Incompatibility between plugin's name and its commands
  • A feature of the zkvyper compiler to produce different contract bytecode depending of project's contracts context

Evidence 📷

image

@FilipTxFusion FilipTxFusion requested a review from a team as a code owner September 2, 2023 12:03
@github-actions
Copy link

github-actions bot commented Sep 2, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit fa8a35f):

https://aqwzx-zksync-v2-docs--pr687-filiptxfusion-verify-as59j06i.web.app

(expires Tue, 12 Sep 2023 10:33:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

@idea404 idea404 enabled auto-merge (squash) September 5, 2023 10:31
@idea404 idea404 merged commit 74d14ac into main Sep 5, 2023
7 checks passed
@idea404 idea404 deleted the FilipTxFusion-verify-vyper branch September 5, 2023 10:33
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idea404 idea404 idea404 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FilipTxFusion @idea404