Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): return withdrawals for address for l1 and l2 addrs matches #378

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(storage): return withdrawals for address for l1 and l2 addrs matches #378

merged 1 commit into from
Jan 30, 2024

Conversation

montekki
Copy link
Member

@montekki montekki commented Jan 30, 2024 •
edited

What ❔

When address A makes withdrawal to address B, api will only show that withdrawal on address B. While we want to show it for both A and B.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt.

@montekki montekki merged commit b0628f1 into main Jan 30, 2024
8 checks passed
@montekki montekki deleted the fvs-api-fixes branch January 30, 2024 20:51
@release-please release-please bot mentioned this pull request Jan 30, 2024
Merged
montekki pushed a commit that referenced this pull request Jan 30, 2024
@release-please
chore(main): release 0.6.3 (#379)
43a8a15 
🤖 I have created a release *beep* *boop*
---


##
[0.6.3](v0.6.2...v0.6.3)
(2024-01-30)


### Bug Fixes

* **storage:** return withdrawals for address for l1 and l2 addrs
matches
([#378](#378))
([b0628f1](b0628f1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
montekki added a commit that referenced this pull request Feb 21, 2024
@montekki
Revert "fix(storage): return withdrawals for address for l1 and l2 ad…
46c6a18 
…drs matches (#378)"

This reverts commit b0628f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaVashchuk AnastasiiaVashchuk Awaiting requested review from AnastasiiaVashchuk AnastasiiaVashchuk is a code owner

@Deniallugo Deniallugo Awaiting requested review from Deniallugo Deniallugo is a code owner

@haraldh haraldh Awaiting requested review from haraldh haraldh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@montekki