New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacement of bitmap icons with SVG icons #27
Conversation
Hey @shinsenter |
Actually I have just tried to use svg path and pass it directly to SvgPicture.asset and in that case it seems to be instant. |
Seem to be fine with the |
@mattermoran It seems that the size of the icons affects the rendering speed, I will try reducing the size of the icons to 256pt (currently 1024pt). |
@mattermoran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks way better now. Still not as fast as pngs but there's just milliseconds difference so it's fine. I will be merging this now, then update the icons and make a release. Good job!
@mattermoran |
hey @shinsenter |
@mattermoran |
Why was the intl package added as a dependancy ? |
@aseef17 probably by mistake. I'm pretty sure I removed it in an actual release |
This can help reduce the size of the package after it is compiled.
Related to the issue #17.
@mattermoran
TODO: SVG files are temporarily added. Replace them with better SVG files.