-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define "small improvement" in Contributor's Guide #1028
Comments
Examples |
Would the term "incremental improvement" in place of "small improvement" be more or less self-explanatory here? |
I agree with @JeffSchering on using the term "incremental improvement". |
See #1083 for proposed changes |
@JeffSchering when I read "incremental" the first thing that comes to mind is something that will be on-going(so it sounds as if I am enlisting myself to a on-going improvement task) whereas "small" comes in as something of minor, in a fixed size. I do think that incremental would fit more in the "technical writing" jargon but as a person that often misunderstand technical writing, I would say "small" is much more friendly, or perhaps "minor improvement". Then again that is just my personal opinion, and perhaps I am the minority that sees it that way, or rather read it that way. |
Thanks @prixone for the feedback, really appreciate your input here. I added a comment in my PR, which had a related note, feel free to add any feedback? #1083 (comment) |
We need to update https://docs.mattermost.com/developer/contribution-guide.html with definition and examples of "small improvement".
Criteria:
Examples (need to link to PR examples, we can probably fine better examples than these):
The text was updated successfully, but these errors were encountered: