Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Adding a new view does not switch to it on v0.8.0 plugin #718

Closed
chenilim opened this issue Jul 13, 2021 · 7 comments
Closed

Bug: Adding a new view does not switch to it on v0.8.0 plugin #718

chenilim opened this issue Jul 13, 2021 · 7 comments
Assignees
Labels
Bug Something isn't working Regression This is a regression from previously working functionality in a released version

Comments

@chenilim
Copy link
Member

Steps to reproduce the behavior:

  1. Install Focalboard plugin v0.8.0 on Mattermost 5.37
  2. Create a board (e.g. the Project Tasks template)
  3. Add a new view, e.g. a Gallery view (but any will do)
  4. The new view does not appear
  5. And clicking on the new view name in the sidebar does not open it
  6. Only after a refresh (Cmd+R), can I open the new view

Expected behavior:
The new view should open immediately after creating.

Platform:

  • Focalboard plugin v0.8.0 on MM 5.37
  • Chrome 91 on macOS

Additional context:
This does not repro on the v0.8.0 standalone macOS app. Appears to be related to the plugin, and appears to be a regression.

@chenilim chenilim added the Bug Something isn't working label Jul 13, 2021
@chenilim
Copy link
Member Author

@harshilsharma63, could you help with the initial investigation of this, and reassign if appropriate? It's a pretty bad regression that we will want to cherry pick for 0.8.x. You can repro this on mysql.test if needed. Thanks.

@chenilim chenilim added the Regression This is a regression from previously working functionality in a released version label Jul 16, 2021
@harshilsharma63
Copy link
Member

harshilsharma63 commented Jul 19, 2021

@chenilim This PR by @jespino fixed this issue as a side effect - #649

You can try the same on the test Mattermost instance you specified in your comment above.

@chenilim
Copy link
Member Author

@jespino please fix this on release-0.8.0.

@jespino
Copy link
Member

jespino commented Jul 30, 2021

This is already fixed in the redux branch, I think we can wait until get that branch merged.

@jespino
Copy link
Member

jespino commented Aug 2, 2021

Already merged in main, closing this.

@jespino jespino closed this as completed Aug 2, 2021
@chenilim
Copy link
Member Author

chenilim commented Aug 3, 2021

We need to fix this on the release-0.8.0' branch in order to ship to Cloud prod. Can you make the fix on release-0.8.0`?

Without this fix, it would delay pushing Focalboard to Cloud. Unfortunately, the redux change is fairly large, so I don't think this can simply be cherry picked, and will need to be re-fixed on the old code. cc @sbishel

@jespino
Copy link
Member

jespino commented Aug 3, 2021

Submitted a solution for 0.8.0

@chenilim chenilim closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Regression This is a regression from previously working functionality in a released version
Projects
None yet
Development

No branches or pull requests

3 participants