Bug: Property values disappear when renaming property

[chenilim]

Steps to reproduce the behavior:

1. Open a card (e.g. from the Project management template)
2. Rename a Select property (e.g. Priority)
3. The values become "(UNKNOWN)"

Expected behavior:
The values should be unaffected by a property rename

Screenshots:
https://user-images.githubusercontent.com/46905241/125990822-37b94f62-1164-4503-a9eb-90bc2602d9c9.mov

Platform:

• Focalboard plugin v0.8.1 (on community server)

Additional context:
This is a high-severity regression.

[chenilim]

@hahmadia, could you help investigate this? It's a regression. We will want to cherry-pick a fix for release-0.8.0. Thanks. cc @harshilsharma63.

[kamre]

Regression was introduced in #553 when changing of type and name was merged into a single function Mutator.changePropertyTypeAndName because all options for new property template are always reset now and before there was a separate simple renaming.

Probably can be fixed with check if type was actually changed:

        if (propertyTemplate.type !== newType) {
            newTemplate.options = []
        }
        newTemplate.type = newType
        newTemplate.name = newName

[harshilsharma63]

@kamre as always, thanks a ton for the investigation 👍