MM-34586 Custom status feature #5220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom status actions and API integration Added custom status selectors and types Added custom status emoji component Added EnableCustomStatuses flag in config Added Set a status option in the settings sidebar
Fixed the default emoji in the set a status in the settings sidebar Made a custom status label component to match the styling of rest of the drawer items Fixed the bug in the selectors Added localization id in en.json
Fixed the custom status label issue Added styling and icon for the clear button Fixed order of the localization ids
Fixed the long custom status overflowing in the sidebar with ellipses Added the functionality to open custom status modal from sidebar Made the constants for custom status Made the custom status suggestion functional component Made the custom status modal functional component Made the selector for the recent custom statuses Added some localization ids
Added recent custom statuses in the modal Fixed the styling of titles Fixed lint errors except one
Refactored the code of the custom status label to a different file and used it everywhere Made a separate component for clear button and added it in recents and sidebar Fixed the styling of the custom status text according to the new figma designs
Fixed the Done button in custom status modal Added the functionality to clear status from inside the modal
Added custom status in user profile page Added custom status emoji in post header Added functionality to preventDoubleTap everywhere Added localization ids Review fixes
Increased touch area of clear button everywhere Fixed the event propagation issue in clearing suggestions Fixed the center alignment issue of title in custom status modal Added clear button in user profile page Review fixes
…ile into MI-1190 * 'MI-1190' of github.com:brightscout-alpha/mattermost-mobile: Fixed types and separated functions for Recent and suggestions in custom status modal
Started with the custom status feature
Changed names of some variables
Fixed clear button border radius issue in ios Changed the method to post in removeRecentCustomStatus API call Made the custom status modal input single line and fixed the height Changed the height of iconContainer in custom status suggestion
…st-mobile into custom-status * 'custom-status' of github.com:brightscout-alpha/mattermost-mobile: Added emojipicker in custom status modal Fixed the Done button in custom status modal Added the functionality to clear status from inside the modal Refactored some code and made clear button component Refactored the code of the custom status label to a different file and used it everywhere Made a separate component for clear button and added it in recents and sidebar Fixed the styling of the custom status text according to the new figma designs Update types Fix types and use i18n translations Changed the custom status modal to class component Added recent custom statuses in the modal Fixed the styling of titles Fixed lint errors except one Made custom status modal with suggestions Fixed the long custom status overflowing in the sidebar with ellipses Added the functionality to open custom status modal from sidebar Made the constants for custom status Made the custom status suggestion functional component Made the custom status modal functional component Made the selector for the recent custom statuses Added some localization ids Added icon for clear button Fixed the custom status label issue Added styling and icon for the clear button Fixed order of the localization ids Fixed emoji and added clear button Fixed the default emoji in the set a status in the settings sidebar Made a custom status label component to match the styling of rest of the drawer items Fixed the bug in the selectors Added localization id in en.json Started with the custom status feature Added custom status actions and API integration Added custom status selectors and types Added custom status emoji component Added EnableCustomStatuses flag in config Added Set a status option in the settings sidebar
- Added custom status in user profile page - Added custom status emoji in post header - Added functionality to preventDoubleTap everywhere - Added localization ids
|
Hello @chetanyakan, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Wow, good eye @ogi-m. It does appear to be very slightly larger than what is in the design. The design had the font-size set to 18, but it looks like it might be 20 here. |
|
@ogi-m @matthewbirtch Changed the emoji size in the channel title. Good for re-review. |
|
The PR won't be merge without the server check.. I rather be on the safe side. |
enahum
added
the
CherryPick/Approved
ogi-m
added
the
Build Apps for PR
|
Building app in separate branch. |
mattermod
removed
the
Build Apps for PR
ogi-m
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
LGTM, @manojmalik20 please add the server version check back and we can merge.
ogi-m
added
4: Reviews Complete
Fixed the lint errors and type check errors
|
I've resolved all the conflicts. @matthewbirtch and @ogi-m Do you want to review again or should I add the server version check? |
Fixed the prop type isMilitaryTime for user_profile screen
|
@manojmalik20 I think we're good, please add the server version check 👍🏻 |
enahum
approved these changes
Jun 4, 2021
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-mobile
that referenced
this pull request
Jun 4, 2021
(cherry picked from commit e442275)
mattermod
added
CherryPick/Done
enahum
pushed a commit
that referenced
this pull request
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Checklist
Device Information
This PR was tested on:
Screenshots
Release Note