Initial Plugin Review

[jfrerich]

This issue includes the checklist for initial PR review. These checklist items are for the reviewer to track and addressed before the plugin in considered Passing Initial Review Process.

When all checklist items are passing and the initial review PR is merged to master, this issue can be marked as closed.

PR Checklist

Jira Ticket

https://mattermost.atlassian.net/browse/MM-21873

Overall comments

For reviewer

• what is official convention for plugin.json id naming?
  • com.mattermost.plugin-agenda
  • com.mattermost.agenda-plugin
  • com.mattermost.agenda

Plugin Metadata

• Plugin name is intention revealing
  • plugin.json - id begins with com.mattermost.<plugin_name>
• Slash command /agenda - intention revealing
• homepage_url: url github repo for plugin
  • make apply causes panic. leave out for now
• support_url: url to /issues
  Example: -> https://github.com/mattermost/mattermost-plugin-custom-attributes/pull/19/files#submit-review
• icon for plugin (if doesn't exist, create ticket to generate one)
• min_server_version

Comparison with common files from mattermost-plugin-starter-template

• git pull from starter-template to see the diffs in the common files (Ticket created: https://mattermost.atlassian.net/browse/MM-22048)

Installation

• make runs without errors - fixed errors
• FAILS make golint has errors - fixed errors (In PR - Plugin review proposals #3)
• make govet has shadow errors - fixed errors

Security

• FAILS npm audit returns no issues (run from webapp/)
  • PR Submitted update latest dependencies #4
  • make clean to remove node_modules/ dir
  • npm audit to find display issues
  • npm audit fix to fix issues

Functionality

README.md

Clear instructions

• necessary screenshots/gifs

Slash command testing

• works - /agenda
• works - /agenda list
• works - /agenda list next-week
• works - /agenda queue
• works - /agenda queue next-week
• works - /agenda setting <int>

Unit Testing

• TBD