Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda list command does not work on mobile #50

Open
DHaussermann opened this issue Jul 23, 2020 · 5 comments
Open

Agenda list command does not work on mobile #50

DHaussermann opened this issue Jul 23, 2020 · 5 comments
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@DHaussermann
Copy link

DHaussermann commented Jul 23, 2020

The design of Agenda for showing list in the RHS work well in webapp but it does not accommodate the mobile app.

When you run /agenda list on mobile nothing seems to happens

Steps:

  • Open a channel
  • Queue some items
  • From RN type /agenda list

Observed: Nothing happened
Expected: Not sure. If the behavior is consistent with other hashtag searches, I suppose it should open some search results for the appropriate hashtag.

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Jul 23, 2020
@marianunez
Copy link
Contributor

The /agenda list command is tightly coupled with the UI and unfortunately plugins UI actions are currently not supported in mobile. I would consider this an enhancement more than a bug.

@DHaussermann DHaussermann added Type/Enhancement New feature or improvement of existing feature and removed Type/Bug Something isn't working labels Jul 23, 2020
@hanzei
Copy link
Contributor

hanzei commented Aug 5, 2020

/agenda list should show a ephemeral message with all the agenda items on mobile.

@hanzei hanzei added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Triage labels Aug 5, 2020
@marianunez
Copy link
Contributor

/agenda list should show a ephemeral message with all the agenda items on mobile.

@hanzei Do we want this ephemeral message also in the webapp that already opens the RHS? How will the plugin know If the command is from mobile to act different?

@hanzei
Copy link
Contributor

hanzei commented Aug 5, 2020

According to @larkox it's possible to detect the type of client that is used to trigger a slash command. It should just be a normal ephemeral post.

@larkox
Copy link

larkox commented Aug 5, 2020

The way to access this is checking args.Session.IsMobileApp().
Nevertheless, apparently the Session part is to be deprecated eventually (v6.0) so not sure if we should use it or not. If we were not to use that, not sure how we can access this information (getting the session from the session ID in the context maybe?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

6 participants