Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp bad export of AdvancedCreateComment #120

Open
crspeller opened this issue Jan 23, 2024 · 0 comments
Open

Webapp bad export of AdvancedCreateComment #120

crspeller opened this issue Jan 23, 2024 · 0 comments

Comments

@crspeller
Copy link
Member

Description

The MM Webapp does not export AdvancedCreateComment directly. Instead it sets a bunch of incorrect parameters and only allows changes to placeholder and onSubmit. See: https://github.com/mattermost/mattermost/blob/master/webapp/channels/src/plugins/exported_create_post.tsx#L15

This caused a bug in the RHS for non-admin users requiring an unpleasant workaround.

This ticket is to fix the webapp and come up with a migration path away from the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant