MM-18590 - Custom Admin Settings #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianunez
added
1: UX Review
lieut-data
approved these changes
Jan 31, 2020
webapp/src/components/admin_settings/users_input/users_input.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/admin_settings/custom_attribute_settings.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/admin_settings/custom_attribute/custom_attribute.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/admin_settings/custom_attribute/custom_attribute.jsx
Outdated
Show resolved
Hide resolved
crspeller
approved these changes
Jan 31, 2020
asaadmahmood
approved these changes
Feb 3, 2020
prapti
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented custom admin settings to configure custom attribute that can have name with the associated users and/or groups that it would be applied to.
This first implementation of this UI allows for users to be searched and selected by username. Groups must be added by group id separated by a space (due to limitations by MM-22071)
Screenshots
Ticket Link
MM-18590