Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute label foreground colour using WCAG rules #130

Closed
mattermod opened this issue Sep 30, 2019 · 1 comment · Fixed by #258
Closed

Compute label foreground colour using WCAG rules #130

mattermod opened this issue Sep 30, 2019 · 1 comment · Fixed by #258
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature

Comments

@mattermod
Copy link
Contributor

The pending update to the GitHub plugin supports a RHS that renders labels on PRs:
image

Unfortunately, sometimes GitHub renders different foreground colours for the given label colour:
image

Investigate rtsao/gh-label-svg#2 and following the WCAG algorithm proposed there to converge on the right white or black foreground colour. If we can find the authoritative algorithm, use that instead.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-19019
@hanzei hanzei transferred this issue from mattermost/mattermost Oct 2, 2019
@hanzei hanzei added Enhancement Hacktoberfest Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Oct 2, 2019
@hanzei hanzei changed the title GitHub Plugin: Compute label foreground colour using WCAG rules Compute label foreground colour using WCAG rules Oct 4, 2019
@hanzei hanzei added Difficulty/2:Medium Medium ticket Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Good First Issue Suitable for first-time contributors and removed Enhancement labels Mar 7, 2020
@hanzei hanzei mentioned this issue May 5, 2020
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label May 5, 2020
@hanzei
Copy link
Contributor

hanzei commented May 5, 2020

@fedealconada is working on this in #258 (review)

@hanzei hanzei linked a pull request May 5, 2020 that will close this issue
[GH-255] Add tooltip for pull request and issue links #258
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-255] Add tooltip for pull request and issue links fedealconada/mattermost-plugin-github
3 participants
@mattermod @hanzei @amyblais