Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make links to comments have the full comment link in the URL #142

Closed
mickmister opened this issue Oct 14, 2019 · 2 comments · Fixed by #143
Closed

Make links to comments have the full comment link in the URL #142

mickmister opened this issue Oct 14, 2019 · 2 comments · Fixed by #143
Assignees
@malaDev
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go

Comments

@mickmister
Copy link
Member

Summary

Currently, a (username) commented on your pull request DM message from the Github bot will link to the associated pull request or issue, but will not include the full link to the comment. Because of this, the user is not taken directly to the comment when they click the link.

To improve UX of this feature, the user should be taken to the comment or review that caused the notification.

Ticket Link

https://mattermost.atlassian.net/browse/MM-19443
@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Tech/Go labels Oct 14, 2019
@malaDev
Copy link
Contributor

malaDev commented Oct 14, 2019

I pick this one

@mickmister mickmister removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 14, 2019
@mickmister
Copy link
Member Author

Awesome, thanks @malaDev!

@hanzei hanzei added the Difficulty/1:Easy Easy ticket label Oct 15, 2019
@hanzei hanzei assigned hanzei and malaDev and unassigned hanzei Oct 15, 2019
@malaDev malaDev mentioned this issue Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malaDev malaDev

Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MM-19443] Link to the comment that cause the notification malaDev/mattermost-plugin-github
4 participants
@malaDev @mickmister @hanzei @amyblais