Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates to properly wrap the whole body with quotes #281

Closed
larkox opened this issue May 21, 2020 · 0 comments · Fixed by #319
Closed

Fix templates to properly wrap the whole body with quotes #281

larkox opened this issue May 21, 2020 · 0 comments · Fixed by #319
Labels
Difficulty/3:Hard Hard ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@larkox
Copy link
Contributor

larkox commented May 21, 2020

Several templates are formed like this:

>{{.GetPullRequest.GetBody | trimBody | replaceAllGitHubUsernames}}

If the body had several line breaks, this may format the body as:

> A

B

This will make the first line be quoted but the second not. In order to avoid this, every line break should have a >. i.e.:

> A
>
> B

This changes should be covered by a lot of unit tests to ensure no edge cases are missed.

@larkox larkox added the Triage label May 21, 2020
@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature Difficulty/2:Medium Medium ticket Difficulty/3:Hard Hard ticket Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/Go and removed Triage Difficulty/2:Medium Medium ticket labels May 21, 2020
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/3:Hard Hard ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants