-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No pr review notifications if my team was assigned as reviewer #704
Comments
@nielmistry @mickmister I tried to reproduce the issue on our end but it seems to be working fine when we are assigning a team as a reviewer on a PR. Each member of the team is getting notified about the review request except in the following cases:
Can you please confirm you are not facing the issue because of the above two points? |
Hey @raghavaggarwal2308 thanks for the reply. There have been quite a few PR requests made to a team that I'm a part of and I've not received any notifications. I wasn't the person who authored most of those PRs. |
@nielmistry Are you the only one facing the issue or the other team members are also not getting notified? Also can you provide me the following details so that we can try to debug the issue further:
|
@nielmistry Are you still facing the issue or we can close it? |
Linked this plugin to mattermost, I get PR review notifications if my account specifically is selected as reviewer. My account is also part of the "software" team on Github, but when the whole software team is assigned I do not get notified
Looked through the source code and doesn't look like it handles the case where the team was assigned:
mattermost-plugin-github/server/plugin/webhook.go
Lines 1176 to 1184 in 52beef2
I think this also applies to issues as well
The text was updated successfully, but these errors were encountered: