Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral message "Not able to get list of webhooks" after creating a subscription #732

Open
mickmister opened this issue Jan 25, 2024 · 3 comments · May be fixed by #770
Open

Ephemeral message "Not able to get list of webhooks" after creating a subscription #732

mickmister opened this issue Jan 25, 2024 · 3 comments · May be fixed by #770
Assignees
Milestone

Comments

@mickmister
Copy link
Member

I'm seeing this error message after creating a subscription

Not able to get the list of webhooks. This feature is not available for subscription to a user.

I'm thinking it may be better to not return an error in this case, and just show the subscription post instead

@ayusht2810 ayusht2810 added this to the v2.3.0 milestone Apr 5, 2024
@ayusht2810
Copy link
Contributor

@mickmister This error is returned when no webhook is configured while creating a subscription from the line.

found, foundErr := p.checkIfConfiguredWebhookExists(ctx, githubClient, repo, owner)
and this was done due to the issue #378 to remind the user that a webhook must be set up. Do we need to update this, or is what we have currently fine?

@ayusht2810 ayusht2810 self-assigned this Apr 5, 2024
@ayusht2810
Copy link
Contributor

@mickmister Should we fix the above issue using the steps mentioned in the issue #715?

@mickmister
Copy link
Member Author

This error is returned when no webhook is configured while creating a subscription from the line.

@ayusht2810 I think what's actually happening here is that I don't have permissions to browse the webhooks in our GitHub org, which is expected. So we should just not show this error in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Submitted / In Review
Development

Successfully merging a pull request may close this issue.

2 participants