Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate GolangCI-Lint #206

Closed
hanzei opened this issue Sep 15, 2020 · 2 comments · Fixed by #208
Closed

Integrate GolangCI-Lint #206

hanzei opened this issue Sep 15, 2020 · 2 comments · Fixed by #208
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Task A general task

Comments

@hanzei
Copy link
Collaborator

hanzei commented Sep 15, 2020

Mattermost is currently in the process of using golangci-lint as the default linter for all go projects. mattermost-community/mattermost-plugin-autolink#108 serves as an example of how the migration should look like:

  1. Copy .golangci.yml from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  2. Copy Makefile from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  3. Copy build/ from https://github.com/mattermost/mattermost-plugin-autolink/ into this repository.
  4. Run go mod tidy and make dist to ensure the build system works fine.
  5. Update linters-settings.goimports.local-prefixes to the go module path i.e. to github.com/mattermost/mattermost-plugin-aws-SNS.
  6. Run make golangci-lint and fix all issues that arise.

Fixing an linter issue is sometimes trivial but can also be quite complicated. There might be cases, where ignoring an issue using issues.exclude-rules is needed. If you don't know how to resolve an error, please reach out to @hanzei on the Mattermost Community Server or ask the question here.

@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Tech/Go Type/Task A general task labels Sep 15, 2020
@carantunes
Copy link

Hey! Can I do this one?

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Sep 30, 2020
@hanzei
Copy link
Collaborator Author

hanzei commented Sep 30, 2020

@vladimirdotk already submitted a PR. Sorry, I forgot to remove Up For Grabs. You might want to take a look at mattermost-community/mattermost-plugin-jenkins#30 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Task A general task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants