Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching in ci doesn't work #71

Closed
hanzei opened this issue Jul 1, 2019 · 3 comments · Fixed by #73
Closed

Caching in ci doesn't work #71

hanzei opened this issue Jul 1, 2019 · 3 comments · Fixed by #73
Assignees

Comments

@hanzei
Copy link
Collaborator

hanzei commented Jul 1, 2019

On issue with this setup is that the caching doesn't work. The orb expects the go.mod file to be at /go.mod. But in this project it's at /server/go.mod.
I see
Screenshot from 2019-06-24 07-45-29

Possible options:

  1. Ignore this problem
  2. Move go.mod into the root directory
  3. Modify the orb to make this customizable

@manland Thoughts on this?

Originally posted by @hanzei in #69 (comment)

@manland
Copy link
Contributor

manland commented Jul 1, 2019

I 👍 to be like other plugins! If others have go.mod at root instead of server I'm ok to move it ;)

@hanzei
Copy link
Collaborator Author

hanzei commented Jul 1, 2019

Should I or do you want to take care of this?

@hanzei hanzei added the Bug label Jul 1, 2019
@manland
Copy link
Contributor

manland commented Jul 1, 2019

Yes you should go for it, you seams to be on steroids tonight! I can't stop you 😁 ! And thanks for you help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants