Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server-side validation to Subscription APIs #313

Closed
levb opened this issue Sep 9, 2019 · 7 comments
Closed

Add server-side validation to Subscription APIs #313

levb opened this issue Sep 9, 2019 · 7 comments
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go
Milestone

Comments

@levb
Copy link
Contributor

levb commented Sep 9, 2019

Subscription management APIs,

func httpChannelSubscriptions(p *Plugin, w http.ResponseWriter, r *http.Request) (int, error) {
, should implement server-side data validation, they currently rely on the webapp submitting valid data.

https://mattermost.atlassian.net/browse/MM-17903


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Plugin: Jira" community channel.

New contributors please see our Developer's Guide and our Plugins Guide.

@levb levb added Enhancement Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Sep 9, 2019
@shovanmaity
Copy link

hi @levb i would like to take it

@levb levb removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 14, 2019
@levb
Copy link
Contributor Author

levb commented Nov 12, 2019

@imazik are you intending to finish this ticket, or should we put it back in the "Up for grabs"?

@levb levb added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Dec 3, 2019
@RajatVaryani
Copy link

@levb Can you please elaborate more on the validations required on server side?

@levb
Copy link
Contributor Author

levb commented Dec 19, 2019

@mickmister This was your ticket, can you please elaborate? Please edit the description as needed?

@levb levb added this to the v2.4 milestone Jan 14, 2020
@jfrerich
Copy link
Contributor

@mickmister, does server-side validation implementation still need to be added?

@mickmister
Copy link
Member

@jfrerich Nope, closing per #432

@jfrerich
Copy link
Contributor

@mickmister Awesome!

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go
Projects
None yet
Development

No branches or pull requests

7 participants