Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override user/icon on for new meeting message #100

Merged
merged 2 commits into from Jun 11, 2020
Merged

Remove override user/icon on for new meeting message #100

merged 2 commits into from Jun 11, 2020

Conversation

jespino
Copy link
Contributor

@jespino jespino commented Jun 10, 2020 •
edited

Fixes #99

@jespino jespino requested a review from hanzei June 10, 2020 21:33
@jespino jespino added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 10, 2020
hanzei
hanzei suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about at Prop

server/plugin.go Outdated Show resolved Hide resolved
@jespino jespino requested a review from hanzei June 11, 2020 08:49
hanzei
hanzei approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jun 11, 2020
@hanzei hanzei added this to the v2.0.0 milestone Jun 11, 2020
@jespino jespino merged commit f899f42 into mattermost-community:master Jun 11, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Create meeting post should use username and icon
2 participants
@jespino @hanzei