Legal hold job is recreated on any server config change

[mickmister]

This plugin makes an assumption that the RPC hook OnConfigurationChange is called only when this plugin's settings have changed, but it's called when any server config value is changed. The plugin creates a new legal hold job when this occurs.

The plugin should instead verify that one of its own plugin settings was changed in the process and then reconfigure itself.

---

mattermost-plugin-legal-hold/server/plugin.go

Line 127 in 61943a3

func (p *Plugin) OnConfigurationChange() error {

mattermost-plugin-legal-hold/server/plugin.go

Lines 172 to 179 in 61943a3

	p.legalHoldJob, err = jobs.NewLegalHoldJob(LegalHoldJobID, p.API, p.Client, p.SQLStore, p.KVStore, p.FileBackend)
	if err != nil {
	return fmt.Errorf("cannot create legal hold job: %w", err)
	}
	if err := p.jobManager.AddJob(p.legalHoldJob); err != nil {
	return fmt.Errorf("cannot add legal hold job: %w", err)
	}
	_ = p.jobManager.OnConfigurationChange(p.getConfiguration())

[mickmister]

A PR was raised to address this #47, but it may not be the right solution for the core concern here. The focus on this task should be on verifying the behavior of reconfiguring the job on config change, and ensure that it's resilient to being called potentially often.