Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once a subscription is created, the plugin should post the subscription ID and info to the channel #116

Closed
DHaussermann opened this issue Nov 15, 2022 · 4 comments · Fixed by #169
Labels
Type/Enhancement New feature or improvement of existing feature

Comments

@DHaussermann
Copy link

Once a subscription is created, the plugin should post the subscription ID and info to the channel. This is typical of other integrations. This could either be a post in the channel by the bot or just an ephemeral post to the user creating the subscription.

Currently nothing happens after a subscription save.

This serves to provide feedback that the subscription was created successfully and also shows the ID in case I want to go make an edit right after saving.

note: This is somewhat lower impact on SN as subscriptions are shown in the RHS as well as the list command.

@DHaussermann
Copy link
Author

@manojmalik20 just posting for visibility that this is not resolved by https://github.com/Brightscout/mattermost-plugin-servicenow/pull/121 Keeping issue open.

To be explicit I don't see this being a blocking issue.

@ayusht2810
Copy link
Contributor

@DHaussermann fixed in PR #169. Please verify

@hanzei hanzei linked a pull request May 31, 2023 that will close this issue
@raghavaggarwal2308
Copy link
Contributor

@mickmister @DHaussermann Can we close this issue?

@mickmister
Copy link
Member

Can we close this issue?

@raghavaggarwal2308 It looks like the PR is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
Development

Successfully merging a pull request may close this issue.

5 participants