Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty block space under Favorites #17648

Closed
camaer opened this issue May 19, 2021 · 8 comments
Closed

Empty block space under Favorites #17648

camaer opened this issue May 19, 2021 · 8 comments

Comments

@camaer
Copy link

camaer commented May 19, 2021

Summary

Since 5.33 or 5.32, I can't remember exactly, an empty block (space ?) appeared underneath my Favorites Channel section. I can move the block around but there is no option to delete it.

Steps to reproduce

Don't know how to reproduce exactly unfortunately. Appeared in 5.33 or 5.32 update. We are currently running the latest version 5.35.1

Expected behavior

No empty space

Observed behavior (that appears unintentional)

Here's a gif that shows what I'm talking about. Appears in MM Desktop client (Mac) and web version. Its fine on Mobile
empty-space-mm

Possible fixes

No idea unfortunately

@amyblais
Copy link
Member

@hmhealey Have you seen a report like this before, or do you have thoughts on this?

@hmhealey
Copy link
Member

No, we haven't seen anything like this before. That's really strange. I'm not even sure what that line might be.

In a web browser, could you use the dev tools to show us what the HTML for that space might be? If you could right click on it, click Inspect Element, and send us a screenshot of that like
Screen Shot 2021-05-21 at 10 12 36 AM
that'd be really helpful for us to understand what might be going on there.

@camaer
Copy link
Author

camaer commented May 21, 2021

Here's the inspect element. Seems to be a Channel but without a name or anything.

Screen Shot 2021-05-21 at 10 15 55 AM

Could it be perhaps an old channel that was deleted incorrectly ?

@hmhealey
Copy link
Member

Yeah, that might be the case since the draggable-id attribute looks like a real channel ID. If you have access to the DB, you could confirm whether or not a channel with that "s6cbh..." ID exists.

Either that or there's an error in the library we use for drag and drop. If that were the case, I'd expect to see an error in the browser's console.

@camaer
Copy link
Author

camaer commented May 21, 2021

Seems like I do have a channel s6cbh1poabdwmbt5yxgd7k1h5e

Screen Shot 2021-05-21 at 10 51 07 AM

Should I juste delete the row in the channels table ?

@hmhealey
Copy link
Member

I wouldn't recommend deleting it since that could leave some orphaned data that could cause other problems, but you could try deleting the row in SidebarChannels with that ChannelId and your UserId (only needed if there's multiple rows that match that). That'll remove it from the Favorites category in your sidebar since that table keeps track of where channels appear in the sidebar.

@camaer
Copy link
Author

camaer commented May 21, 2021

That worked ! Thanks for the help. Not sure exactly what happened but at least it's fixed.

@camaer camaer closed this as completed May 21, 2021
@hmhealey
Copy link
Member

Glad that helped! Let us know if that comes up again.

The new sidebar is definitely more complicated than the old one, so stuff like that one can pop up occasionally, but since that's the first time this particular issue has come up, I don't think there's much to investigate on it for now. We can always reopen this if it reappears though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants