Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Wanted] Firefox: CTRL/CMD + U to upload a file does not work #4597

Closed
jasonblais opened this issue Nov 19, 2016 · 5 comments
Closed

[Help Wanted] Firefox: CTRL/CMD + U to upload a file does not work #4597

jasonblais opened this issue Nov 19, 2016 · 5 comments

Comments

@jasonblais
Copy link
Contributor

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team.

For technical advice or questions, please join our "Developers" community channel.


Difficulty: Intermediate

Details: Jira ticket

Repro:

  1. Sign into Mattermost on a Firefox browser
  2. Set focus to a message box
  3. Hit CTRL/CMD + U

Observed: No action taken

Expected: A dialog opens, letting you upload files.

@jasonblais jasonblais added the Difficulty/2:Medium Medium ticket label Nov 19, 2016
@jwilander jwilander added the Tech/ReactJS Web app label Nov 22, 2016
@Rudloff
Copy link
Contributor

Rudloff commented Dec 13, 2016

I can't quite reproduce on Firefox 52.0a2 (on Linux). I get a warning about a popup window for some reason but if I allow popups it then works correctly.

@jwilander jwilander removed the Hackfest label Jan 9, 2017
@jasonblais
Copy link
Contributor Author

@Rudloff I tried on Windows 10, Firefox and it seems to reproduce

I didn't get any warnings about a popup window so I'm not sure if that's why.

@tejasbubane
Copy link

tejasbubane commented Feb 22, 2019

I was not able to reproduce this on Firefox 65.0.1 (64-bit) on MacOS Mojave 10.14.3. Pressing Cmd-U opened a file upload box. Is this OS specific?

@DHaussermann
Copy link

DHaussermann commented Feb 22, 2019

I tested this on 2 different Windows 10 machines and can't repo an issue.

On FireFox 54 - I was prompted by the pop-up blocker and had to allow the pop-up (or trust the site) to get the file window open.

On FireFox 65 - The file window opened without issue.

It may be that some users are not seeing the prompt to allow the pop-up if the browser is configured to hide it.

@jasonblais
Copy link
Contributor Author

Thanks @DHaussermann for verifying! Given it doesn't reproduce on Mac/Linux (from above testing, thanks all!), and we don't support Firefox 54, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants