Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-13492 Allow empty channel in /channels/view #10062

Merged
merged 2 commits into from Jan 7, 2019
Merged

MM-13492 Allow empty channel in /channels/view #10062

merged 2 commits into from Jan 7, 2019

Conversation

crspeller
Copy link
Member

Fixes a bug where the server was rejecting viewing no channel represented by "". This happens when the browser loses focus.

@crspeller crspeller added the 2: Dev Review Requires review by a developer label Jan 3, 2019
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (1 nit aside)

api4/channel.go Outdated Show resolved Hide resolved
@crspeller crspeller merged commit ca4dcf4 into master Jan 7, 2019
@crspeller crspeller deleted the mm-13492 branch January 7, 2019 22:07
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Jan 8, 2019
@lindy65 lindy65 added Tests/Not Needed New release tests not required and removed 4: Reviews Complete All reviewers have approved the pull request labels Jan 8, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants