Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logging of CSRF Warning #11630

Merged
merged 1 commit into from Jul 17, 2019
Merged

Enhance logging of CSRF Warning #11630

merged 1 commit into from Jul 17, 2019

Conversation

DSchalla
Copy link
Member

Summary

This pull request implements enhanced logging for CSRF warnings, adding the following information to each request:

  • Remote Adddress
  • Path
  • User ID
  • Session ID

The goal of this pull request is to simplify debugging of CSRF warnings.

@DSchalla DSchalla added the 2: Dev Review Requires review by a developer label Jul 15, 2019
@DSchalla DSchalla added this to the v5.14.0 milestone Jul 15, 2019
@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Jul 17, 2019
@hmhealey hmhealey merged commit cb534c7 into master Jul 17, 2019
@hmhealey hmhealey deleted the csrf-log branch July 17, 2019 13:09
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Jul 23, 2019
@wiersgallak wiersgallak added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants