MM-18068 Route integration actions to plugins without hitting the network

[scottleedavis]

Summary

Routes integration actions to plugins without hitting the network and instead calls hooks.ServeHTTP directly

Ticket Link

Fixes #11964

[hanzei]

@scottleedavis Head up: @crspeller was out last week and will be out this week. And @lieut-data is a bit overloaded with reviews. Hence, it will take some time to review this. Sorry for the delay.

[hanzei]

@gabrieljackson Can you help and jump in?

[scottleedavis]

No worries @hanzei . I am happy to see this through to completion regardless of delay.

[lieut-data]

Thanks for taking a stab at this, @scottleedavis! Comments below :)

[gabrieljackson]

This is coming along nicely! A few comments below.

[lieut-data]

Looks good, @scottleedavis! Just one change requested in the unit tests below.

[scottleedavis]

gentle reminder for review @DHaussermann

[scottleedavis]

test failures involve node_modules and redux, ergo I believe is not related to this PR.

[DHaussermann]

@scottleedavis or @lieut-data Can you please provide some guidance or test steps on this? Can I verify this on the Spinwick server by watching client-side web traffic? I'm not sure I fully understand the problem being solved.

[lieut-data]

@DHaussermann, previously, when an integration action was posted to a plugin, the flow was:

client -> server -> http request to http://site_url -> server -> plugin

This created problems whenever the server couldn't actually connect to its own site url for any number of reasons. Now, the behaviour is effectively:

client -> server -> plugin

since the server realizes it's a relative URL and skips the network lookup altogether.

It may be possible to test this on the spinwick by setting a bogus SiteURL.

[DHaussermann]

Regression tested by ensuring post actions still work. Used Giphy and Matterpoll to confirm.
LGTM!

[hanzei]

@scottleedavis Can you please merge master into this? Then we can merge.

[scottleedavis]

complete. build test failures look unrelated.

[mattermod]

Test server destroyed

[lieut-data]

Indeed, the CircleCI errors seem specious. The required tests have passed, so I think we're good here: merging. And thanks, @scottleedavis, as always :)

[boredomdenied]

I seem to be having an issue related to this in some way. Would you mind taking a look at the issue mentioned above @scottleedavis Thank you.