Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-17797] Add Timeout To SMTP Connection #13251

Merged
merged 19 commits into from Mar 10, 2020
Merged

[MM-17797] Add Timeout To SMTP Connection #13251

merged 19 commits into from Mar 10, 2020

Conversation

isacikgoz
Copy link
Member

Summary

This PR fixes the stuck issue if the configured mail server is listening but not responding.

Ticket Link

Fixes #11777

@isacikgoz isacikgoz changed the title Add timout to smtp conn [MM-17797] Add Timeout To SMTP Connection Nov 29, 2019
@mgdelacroix mgdelacroix requested review from mgdelacroix and a team November 29, 2019 16:55
@ghost ghost requested review from gigawhitlocks and removed request for a team November 29, 2019 16:55
@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Nov 30, 2019
mgdelacroix
mgdelacroix requested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I can still reproduce the issue following the instructions from the ticket; opening a port with nc -l -p 26 hangs Mattermost server. @isacikgoz could you please check if it works for you?

@isacikgoz
Copy link
Member Author

@mgdelacroix Thank you for reviewing my PR. I was expecting same behavior from net.Dial to be like tls.Dial. It turns out that they are different :) I added a read/write deadline to the connection so that while doing a SMTP handshake it will get i/o timeout if there is a problem.

Initial implementation was tested with TLS connection which does a handshake at the very beginning unlike net.Dial.

@gigawhitlocks gigawhitlocks removed their request for review December 10, 2019 18:53
@hanzei hanzei requested a review from reflog December 20, 2019 22:15
reflog
reflog approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattermod
Copy link
Contributor

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

@jasonblais
Copy link
Contributor

@mgdelacroix quick reminder to help with review, thanks! :)

mgdelacroix
mgdelacroix approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review. LGTM, awesome work @isacikgoz, thanks for the changes!! 🎊

@mgdelacroix mgdelacroix removed 2: Dev Review Requires review by a developer Lifecycle/1:stale labels Jan 22, 2020
@isacikgoz isacikgoz removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Mar 9, 2020
@isacikgoz isacikgoz merged commit 771574b into mattermost:master Mar 10, 2020
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Mar 13, 2020
iomodo pushed a commit that referenced this pull request Mar 25, 2020
@isacikgoz @mattermod @iomodo
[MM-17797] Add Timeout To SMTP Connection (#13251)
7067434 
* model/config: add timeout setting to email settings

* services/mailservice: add timeout to connection

* app/server_app_adapter: show SMTP connection errors on log

* services/mailservice: add r/w deadline to smtp conn

* services/mailservice: add context timeout

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
@amyblais amyblais added Docs/Needed Requires documentation and removed Docs/Not Needed Does not require documentation labels Apr 7, 2020
@amyblais amyblais assigned wiersgallak and unassigned mgdelacroix Apr 7, 2020
@justinegeffen justinegeffen added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Apr 7, 2020
@amyblais amyblais added Docs/Needed Requires documentation and removed Docs/Not Needed Does not require documentation labels Apr 13, 2020
@amyblais
Copy link
Member

@justinegeffen This needs docs to document SMTPServerTimeout setting in config.json doc.

@justinegeffen
Copy link
Contributor

@justinegeffen This needs docs to document SMTPServerTimeout setting in config.json doc.

Thanks for clarifying. I'll submit the PR ASAP.

justinegeffen added a commit to mattermost/docs that referenced this pull request Apr 13, 2020
@justinegeffen
Update config-settings.rst
5d76fc4 
Docs for: mattermost/mattermost#13251.
@justinegeffen justinegeffen mentioned this pull request Apr 13, 2020
Merged
justinegeffen pushed a commit to mattermost/docs that referenced this pull request Apr 13, 2020
Update for mattermost/mattermost#13251.
4e1a7c0
justinegeffen pushed a commit to mattermost/docs that referenced this pull request Apr 13, 2020
Update for mattermost/mattermost#13251
5ca9f5a
@amyblais amyblais added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Apr 13, 2020
amyblais pushed a commit to mattermost/docs that referenced this pull request Apr 15, 2020
@justinegeffen @isacikgoz
Update config-settings.rst (SMTP timeout) (#3515)
4b08829 
* Update config-settings.rst

Docs for: mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251

* Update source/administration/config-settings.rst

Co-Authored-By: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Fixed table formatting.

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
amyblais added a commit to mattermost/docs that referenced this pull request Apr 15, 2020
@amyblais @jasonblais
@justinegeffen @adamjclarkson @esethna @aaronrothschild @wiersgallak @isacikgoz
V5.22 documentation (#3531)
00c70af 
* Update conf.py (#3452)

* Update important-upgrade-notes.rst (#3476)

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst (#3464)

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst (#3488)

* Update open-source-components.rst (#3490)

* Update open-source-components.rst

* Update open-source-components.rst

* Update telemetry docs for 5.22 (#3512)

* Update config-settings.rst (#3506)

* Update config-settings.rst

Update for: mattermost/mattermost#13788.

* Update source/administration/config-settings.rst

* Updated with shortcut to open and close RHS

* Updated with shortcut to open and close RHS

* Updated with shortcut to react to last message

* Updated with shortcut to react to last message (fixed table)

* trying to escape backslash

* Added Team switch shortcuts

* Update mmctl-cli-tool.rst (#3513)

Updated docs in line with: mattermost/mattermost#13986

* Update config-settings.rst (office365 update) (#3507)

* Update config-settings.rst

Added content for: mattermost/mattermost#13737. Formatting changes to Push Notifications section. Formatting change to heading (removed colon).

* Update source/administration/config-settings.rst

* ES v5.22 docs (#3501)

* Add Team Sidebar GIF

* Add Sidebar Phase 1 GIF

* Adding team drag and drop

* Add experimental channel sidebar features

* sidebar experimental features

* Update organizing-conversations.rst

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/help/getting-started/organizing-conversations.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Delete sidebar-phase-1.gif

* Update sidebar phase 1 GIF

* Update config name to ExperimentalChannelSidebarOrganization

* Update config-settings.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Added UserMentions/ChannelMentions to example

- Added ChannelMentions to the example payload
- Added UserMentions to the example payload

* Add docs to unarchive channels (resubmit) (#3511)

* Add docs to unarchive channels

* Add files via upload

* Update organizing-conversations.rst

General editorial review of doc; formatting and punctuation changes committed and minor rewording.

* Update source/help/getting-started/organizing-conversations.rst

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update config-settings.rst (#3517)

* Update config-settings.rst
OpenTracing docs

* Fixed table rendering; rewording.

* Update source/administration/config-settings.rst

Co-authored-by: Justine Geffen <justine.geffen@mattermost.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update config-settings.rst (experimental audit settings) (#3508)

* Update config-settings.rst

First draft of docs for mattermost/mattermost#14062

* Update config-settings.rst

Added updated content as per feedback on mattermost/mattermost#14062

* Update config-settings.rst

Formatting output examples.

* Fixed bad formatting.

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Removed "Experimental" from key names.

* Removed "array" from string input for audit settings.

* Formatting changes, included path.

* Incorporated additional feedback and formatting.

* Added default settings and general review/UI element formatting check.

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Fixed rendering issue with Max size.

* Added descriptions for audit: syslog and file configs.

* Updated config settings as per discussion with @wiggins77.

* Added three additional settings (syslog max queue size, file max queue size, syslog insecure).

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update advanced-permissions.rst (#3496)

* Update advanced-permissions.rst

Added channel moderation section; initial steps.

* Update advanced-permissions.rst

Created example and updated content.

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update advanced-permissions.rst

Removed steps in read-only channel recipes related to unchecking mentions.

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update advanced-permissions.rst

Removed section on public and private channels.

* Update advanced-permissions.rst

Added refined headings to differentiate channel and advanced permissions.

* Update source/deployment/advanced-permissions.rst

Co-Authored-By: Martin Kraft <martinkraft@gmail.com>

* Update advanced-permissions.rst

Updated description and removed reference to version prior to 5.12 for channel moderation.

* Update advanced-permissions.rst

Fixed numbering.

* Update source/deployment/advanced-permissions.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update advanced-permissions.rst

Promote single member to channel admin update.

Co-authored-by: Martin Kraft <martinkraft@gmail.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* v5.22 Changelog (#3451)

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update config-settings.rst (SMTP timeout) (#3515)

* Update config-settings.rst

Docs for: mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251

* Update source/administration/config-settings.rst

Co-Authored-By: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Fixed table formatting.

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Clarkson <adam.clarkson@mattermost.com>
Co-authored-by: Eric Sethna <eric@mattermost.com>
Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>
Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>
Co-authored-by: Justine Geffen <justine.geffen@mattermost.com>
Co-authored-by: Martin Kraft <martinkraft@gmail.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
justinegeffen added a commit to mattermost/docs that referenced this pull request Jul 1, 2020
@justinegeffen @jasonblais
@emilyhollinger @adamjclarkson @svelle @amyblais @esethna @aaronrothschild @wiersgallak @isacikgoz @asaadmahmood @T0biii @Willyfrog @mattermod @metanerd @johnthompson365 @DSchalla @ztrayner @bbodenmiller @akarikuu @hanzei @gramakri @melroy89 @calebroseland @funkytwig @JtheBAB @fakela @alifarooq0 @faase @grundleborg @reflog @psy-q @agnivade @kaakaa @it33 @thefactremains
Admin & Installation docs: Capitalization changes (#3530)
edaa27e 
* Capitalization changes as per: #3462

* Update source/install/config-mattermost-server.rst

* Update source/install/config-mattermost-server.rst

* Update source/install/config-mattermost-server.rst

* Update feature parity table in product FAQ (#3509)

* Update feature parity table in product FAQ

* Update custom UI themes on mobile

* Update working-at-mattermost.rst (#3532)

* Updated to include Account and team setup events, system console events (#3518)

* Updated to include Account and team setup events, system console events

Covering changes related to mattermost/mattermost-webapp#5049 and mattermost/mattermost-webapp#5047

* Update source/administration/telemetry.rst

* Update source/administration/telemetry.rst

* Update telemetry.rst

Bullet-point formatting added and minor punctuation changes.

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update bulk-export-data.rst with post prop information (#3520)

* Update bulk-export-data.rst

* Update bulk-export-data.rst

* Update bulk-loading-data-format.rst

* Update bulk-export-data.rst

* V5.22 documentation (#3531)

* Update conf.py (#3452)

* Update important-upgrade-notes.rst (#3476)

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst (#3464)

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst (#3488)

* Update open-source-components.rst (#3490)

* Update open-source-components.rst

* Update open-source-components.rst

* Update telemetry docs for 5.22 (#3512)

* Update config-settings.rst (#3506)

* Update config-settings.rst

Update for: mattermost/mattermost#13788.

* Update source/administration/config-settings.rst

* Updated with shortcut to open and close RHS

* Updated with shortcut to open and close RHS

* Updated with shortcut to react to last message

* Updated with shortcut to react to last message (fixed table)

* trying to escape backslash

* Added Team switch shortcuts

* Update mmctl-cli-tool.rst (#3513)

Updated docs in line with: mattermost/mattermost#13986

* Update config-settings.rst (office365 update) (#3507)

* Update config-settings.rst

Added content for: mattermost/mattermost#13737. Formatting changes to Push Notifications section. Formatting change to heading (removed colon).

* Update source/administration/config-settings.rst

* ES v5.22 docs (#3501)

* Add Team Sidebar GIF

* Add Sidebar Phase 1 GIF

* Adding team drag and drop

* Add experimental channel sidebar features

* sidebar experimental features

* Update organizing-conversations.rst

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/help/getting-started/organizing-conversations.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Delete sidebar-phase-1.gif

* Update sidebar phase 1 GIF

* Update config name to ExperimentalChannelSidebarOrganization

* Update config-settings.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Added UserMentions/ChannelMentions to example

- Added ChannelMentions to the example payload
- Added UserMentions to the example payload

* Add docs to unarchive channels (resubmit) (#3511)

* Add docs to unarchive channels

* Add files via upload

* Update organizing-conversations.rst

General editorial review of doc; formatting and punctuation changes committed and minor rewording.

* Update source/help/getting-started/organizing-conversations.rst

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update config-settings.rst (#3517)

* Update config-settings.rst
OpenTracing docs

* Fixed table rendering; rewording.

* Update source/administration/config-settings.rst

Co-authored-by: Justine Geffen <justine.geffen@mattermost.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update config-settings.rst (experimental audit settings) (#3508)

* Update config-settings.rst

First draft of docs for mattermost/mattermost#14062

* Update config-settings.rst

Added updated content as per feedback on mattermost/mattermost#14062

* Update config-settings.rst

Formatting output examples.

* Fixed bad formatting.

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Update source/administration/config-settings.rst

* Removed "Experimental" from key names.

* Removed "array" from string input for audit settings.

* Formatting changes, included path.

* Incorporated additional feedback and formatting.

* Added default settings and general review/UI element formatting check.

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/administration/config-settings.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Fixed rendering issue with Max size.

* Added descriptions for audit: syslog and file configs.

* Updated config settings as per discussion with @wiggins77.

* Added three additional settings (syslog max queue size, file max queue size, syslog insecure).

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update advanced-permissions.rst (#3496)

* Update advanced-permissions.rst

Added channel moderation section; initial steps.

* Update advanced-permissions.rst

Created example and updated content.

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update advanced-permissions.rst

Removed steps in read-only channel recipes related to unchecking mentions.

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update source/deployment/advanced-permissions.rst

* Update advanced-permissions.rst

Removed section on public and private channels.

* Update advanced-permissions.rst

Added refined headings to differentiate channel and advanced permissions.

* Update source/deployment/advanced-permissions.rst

Co-Authored-By: Martin Kraft <martinkraft@gmail.com>

* Update advanced-permissions.rst

Updated description and removed reference to version prior to 5.12 for channel moderation.

* Update advanced-permissions.rst

Fixed numbering.

* Update source/deployment/advanced-permissions.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update advanced-permissions.rst

Promote single member to channel admin update.

Co-authored-by: Martin Kraft <martinkraft@gmail.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* v5.22 Changelog (#3451)

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update config-settings.rst (SMTP timeout) (#3515)

* Update config-settings.rst

Docs for: mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251.

* Update for mattermost/mattermost#13251

* Update source/administration/config-settings.rst

Co-Authored-By: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Fixed table formatting.

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Adam Clarkson <adam.clarkson@mattermost.com>
Co-authored-by: Eric Sethna <eric@mattermost.com>
Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>
Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>
Co-authored-by: Justine Geffen <justine.geffen@mattermost.com>
Co-authored-by: Martin Kraft <martinkraft@gmail.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Update version-archive.rst (#3533)

* About Mattermost page moved to handbook (#3525)

* About Mattermost page moved to handbook

* Update handbook.rst

* Update source/process/handbook.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Fixing broken doc (#3536)

* Update organizing-conversations.rst

* Update organizing-conversations.rst

* Update desktop-changelog.rst (#3502)

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update mmctl-cli-tool.rst (#3514)

* Update mmctl-cli-tool.rst

Include strict command, added channel modify command. Editing headers for capitalization.

* Update mmctl-cli-tool.rst

Added docs.

* Update mmctl-cli-tool.rst

Added bot section.

* Update feature-release.md (#3489)

* Update feature-release.md

* Update feature-release.md

* Update feature-release.md

* Update feature-release.md

* Update feature-release.md

* Update important-upgrade-notes.rst (#3540)

* Edited NPS rating options from 4 to 3. (for docs.mattermost.com) (#3494)

* Adding customer thermometer for pages

* Added gtag for Event tracking; ready for review.

* Removed "Good" rating from c-thermometer.

* Updating docs

* Updating popup

* Updating x overlap

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>

* Move PM hiring process to the handbook (#3543)

* Update changelog.md (#3545)

* Update changelog.md

* Update changelog.md

* v5.19.2 docs (#3544)

* Update changelog.md

* Update extended-support-release.rst

* Update version-archive.rst

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update desktop-app-deployment.rst (#3541)

* Update desktop-changelog.rst (#3547)

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop.rst

* Update source/help/apps/desktop-changelog.rst

Co-Authored-By: Guillermo Vayá <guillermo.vaya@mattermost.com>

Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>

* Added GA tracking code to rating widget. (#3552)

* v5.22.1 docs (#3553)

* Update changelog.md

* Update changelog.md

* Update version-archive.rst

* Trigger ci

Co-authored-by: mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>

* Update myscript.js (#3554)

* Added pre-requisite (#3549)

* Added pre-requisite

* Update source/deployment/auth.rst

Co-Authored-By: Daniel Schalla <daniel@schalla.me>

* Update source/deployment/auth.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

* Update source/deployment/auth.rst

Co-authored-by: Daniel Schalla <daniel@schalla.me>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update extended-support-release.rst (#3557)

* Update extended-support-release.rst

* Update extended-support-release.rst

* Update extended-support-release.rst

* Update source/administration/extended-support-release.rst

Co-Authored-By: Jason Blais <13119842+jasonblais@users.noreply.github.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* escaped the double quote so the html renders correctly. (#3558)

* Move release process docs to handbook (#3542)

* Update core.rst

* Update release-faq.rst

* Update feature-release.md

* Update bug-fix-release.md

* Update dot-release.md

* Rename dot-release.md to dot-release.rst

* Update dot-release.rst

* Update and rename feature-release.md to feature-release.rst

* Update and rename bug-fix-release.md to bug-fix-release.rst

* Update and rename security-release.md to security-release.rst

* Update and rename mobile-release-process.md to mobile-release-process.rst

* Update and rename release-tips.md to release-tips.rst

* Update release-scorecard-definitions.rst

* Update source/process/feature-release.rst

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update compliance.rst (#3555)

Formatting changes to UI elements.

* Add reply arrow example (#3546)

* Add reply arrow example

* Update source/help/messaging/sending-messages.rst

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update changelog.md (#3561)

* Update custom-emoji.rst (#3564)

Moved note to higher up in the document for clarity.

* Update upgrade.rst (#3562)

* Update upgrade.rst

* Update source/administration/upgrade.rst

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update myscript.js (#3566)

* Update myscript.js

Changed the value rating to 3,2,1 from 1,2,4.
Changed the message to "How do you rate this page"

* Update myscript.js

Reworded widget text.

* Update migrating.rst (#3559)

* Update migrating.rst

Add mmetl tool to the Slack migration docs

* Update source/administration/migrating.rst

* Update source/administration/migrating.rst

* Update source/administration/migrating.rst

Co-Authored-By: Sven Hüster <sven.svelle@gmail.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Sven Hüster <sven.svelle@gmail.com>

* Update migrating.rst (#3569)

Fixed incorrect numbering in bulk load section.

* Document plugin labels (#3548)

* Document plugin labels

* Apply suggestions from code review

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update migrating.rst (#3571)

* Fix link to Cloudron demo (#3570)

We recently changed our demo location to https://my.demo.cloudron.io

* Introduce Discord Dark themed Mattermost (#3567)

* Migrate development process to new handbook (#3574)

* Update deprecated-features.rst

* Update software-requirements.rst

* Update new-bug-tickets.rst

* Update bug-severity-guidelines.rst

* Delete style-guide.md (#3578)

* Update how-to-run-a-hackathon.rst (#3583)

* Development process overview migrated to handbook (#3577)

Not all content on this page was moved over -- the rest has been shared with Lindsay in a GoogleDoc for next steps

* Update pm-faq.rst (#3573)

* Migrate remaining marketing-related items from legacy handbook (#3584)

* Update asset-guidelines.rst

* Update marketing-guidelines.rst

1 - Add notes about out-of-date pages kept for record-keeping purposes
2 - Migrate Twitter guidelines
3 - Remove release announce guideines -- @amyblais please review and include any valuable ones in https://handbook.mattermost.com/operations/messaging-and-math/how-to-guides-for-m-and-m/how-to-create-release-announcements. I think it's mostly there except maybe the last point about testing on mobile.

* Proposal: Add new section for training & education, move legacy handbook to handbook.mattermost.com (#3526)

* Update header.html

* Create education.rst

* Update administrator.rst

* Update education.rst

* Update index.rst

* Update education.rst

Minor rewording.

* Update header.html

* Update education.rst

* Update index.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Education content fixes (#3588)

* Update education.rst

* Update index.html

* Update core.rst

* Update index.html

* Update changelog.md (#3587)

* Update changelog.md

* Update source/administration/changelog.md

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Add documentation links for webapp message syntax (#3590)

Related PRs:
mattermost/mattermost-webapp#5390

* Move feature quality levels section to product FAQ (#3576)

* Update faq.rst

* Update definitions.rst

* Update changelog.md (#3593)

* Update changelog.md

* Update version-archive.rst

* Update performance-alerting-guide.rst (#3580)

* Update performance-alerting-guide.rst

Added recommendation for installations to set up performance metrics even if not using Grafana or Prometheus.

* Update source/administration/performance-alerting-guide.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update versions from 4.3.0 to 4.4.1 in MSI installer guide (#3591)

* Update versions from 4.3.0 to 4.4.1 in MSI installer guide

* Remove "rc0" from download link

* Update extended-support-release.rst (#3598)

* Update changelog.md (#3599)

* Update changelog.md

* Update changelog.md

* Migrate engineer onboarding doc to handbook (#3585)

Related handbook PR: mattermost/mattermost-handbook#198

Please do not merge until handbook PR has been merged.

* Update engineer-expectations.md (#3600)

* Update administrator.rst (#3597)

Removed /administration/incident-response-application* from TOC/docs.

* Update desktop-changelog.rst (#3592)

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Update desktop-changelog.rst

* Desktop 4.4.2 docs (#3604)

* Update desktop-changelog.rst

* Update desktop.rst

* Update desktop-msi-gpo.rst

* Update desktop-changelog.rst

* Update community-overview.rst (#3582)

* 5.22.3 docs (#3607)

* Update changelog.md

* Update version-archive.rst

* Update changelog.md

* Update version-archive.rst

* Update changelog.md

* Update backup.rst (#3579)

* Update backup.rst

Added 'Please note that to make a 'clean' backup you need to stop mattermost during the duration of the backup otherwise the database and files may become out of sync.'

* Update source/administration/backup.rst

Was not sure about captialisation.

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update Download Link 4.4.1 --> 4.4.2 (#3610)

* Updating docs to reference NAS #3486 (#3602)

* Updating docs to reference NAS #3486

This part of docs was updated to show the NAS suggestions under plugins and high availability, by using a bit of what was said under file storage configuration

* Update source/deployment/cluster.rst

* Update source/deployment/cluster.rst

* Update source/deployment/cluster.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Ali Farooq <ali.farooq0@pm.me>

* Update custom-emoji.rst (#3605)

* Update custom-emoji.rst

Updates to doc including new sections and reorganization to improve rating.

* Update custom-emoji.rst

Added screenshot link; headers.

* Add files via upload

Added Delete Custom Emoji

* Delete Delete_Custom_Emoji.png

* Add files via upload

Resized image

* Update custom-emoji.rst

* Update source/help/settings/custom-emoji.rst

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Add files via upload

New delete screenshot.

* Add files via upload

Replaced file with updated one.

* Delete delete_custom_emoji.png

* Add files via upload

* Update custom-emoji.rst

New image added.

* Add files via upload

Added custom emoji screenshot #2

* Delete delete_custom_emoji.png

* Add files via upload

new "delete Custom Emoji" screenshot

* Update custom-emoji.rst

Moved screenshots around.

* Delete add_custom_emoji.png

* Add files via upload

New "Add Custom Emoji" screenshot.

* Delete delete_custom_emoji.png

* Add files via upload

New "Delete Custom Emoji" screenshot, edited.

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Update install-kubernetes-operator.rst (#3612)

Removed incorrect link.

* New documentation: Account management (#3522)

* Create enterprise-licensing.rst

New file for customer portal docs.

* Update faq.rst

Reorganizing content for customer portal/licensing section.

* Update enterprise-licensing.rst

Added new section for customer portal.

* Update enterprise-licensing.rst

Draft one: Customer Portal docs.

* Update faq.rst

Revert EE section

* Update and rename enterprise-licensing.rst to managing-account.rst

Reorganization of sections.

* Update faq.rst

Reorganization

* Update managing-account.rst

Adding content.

* Content and structure updates.

* Reorganizing content.

* Removed overview from page titles.

* Removed "overview" from header of deployment guide; updates to account management.

* Updated and restructure of content ahead of draft 1 review.

* Reviewed changes.

* Edited introduction.

* Renamed page, edits.

* Included edited from review.

* Update index.rst

Updated index with new page name.

* Update license-and-subscription.rst

Updated formatting and fixed broken links.

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/faq.rst

* Update license-and-subscription.rst

Included updates and feedback from @esadur.

* Update license-and-subscription.rst

Updated introduction content.

* Update license-and-subscription.rst

Rewording for the "single license, multiple servers" FAQ.

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

* Update source/overview/license-and-subscription.rst

Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>

* Update source/deployment/deployment.md

* Update source/overview/architecture.rst

* Update source/overview/compliance.rst

* Update source/overview/integrations.rst

* Update source/overview/product.rst

* Update source/overview/security.rst

* Update license-and-subscription.rst

Fixed broken bullet point, added screenshot.

* Update license-and-subscription.rst

Fixed images link.

* Add files via upload

Customer portal screenshot.

* Update license-and-subscription.rst

Fixed screenshot link.

* Add files via upload

new screenshot for customer portal

* Update license-and-subscription.rst

Added second screenshot for license addition.

* Update license-and-subscription.rst

Removed licensing screenshot, fixed bullet points.

* Update security.rst

Edited header to re-include "Overview"

Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>

* MM-24808: Add "?src= arc" querysting tag to download source for the version archive (#3596)

* MM-24808: Add "?src= arc" querysting tag to download source for the version archive

#### Context:

Right now, multiple sources point to the server binaries on releases.mattermost.com, including the download page, upgrade instructions, Helm charts, version archive, and others.

We can identify the download source by adding a querystring to the url, i.e. https://releases.mattermost.com/5.22.1/mattermost-5.22.1-linux-amd64.tar.gz?src=arc

The intent is that we can then identify sources of downloads, identify those that typically lead to an unsuccessful server activtion, and improve the experience for the developer/administrator.

This PR adds the "?src=arc" querysting tag to download source for the version archive https://docs.mattermost.com/administration/version-archive.html, so we know when someone downloaded it from this page.

* Resolve merge conflicts

* Update ldap-group-sync.rst (#3613)

* Update integrations-directory.rst (#3575)

* Fix typo in mattermost license file in K8s install guide (#3618)

Found by @NOP64

* Rework Logging in General Troubleshooting section (#3539)

* reworked General Troubleshooting section to better represent logging

* Apply suggestions from first code review

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* added suggestions from review

* added suggestion from https://github.com/mattermost/docs/pull/3539/files#r410189955

* Update source/install/troubleshooting.rst

Co-Authored-By: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* fixing a numbered list issue

* Apply suggestions from code review

Co-Authored-By: Justine Geffen <justinegeffen@users.noreply.github.com>

* removing mention of other forums

* Update source/install/troubleshooting.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* applied solution found in comment conversation

* Update source/install/troubleshooting.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* correcting errors in list rendering

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Add 50k AWS architecture. (#3614)

* V5.23 documentation (#3616)

* Update conf.py (#3537)

* Update open-source-components.rst (#3595)

* Update important-upgrade-notes.rst (#3594)

* Update release-lifecycle.rst

* Update telemetry.rst (#3565)

* Update telemetry.rst

Adds Telemetry for 
 - [SMTPServerTimeout](mattermost/mattermost#14283) 
 - [IdleTimeout](mattermost/mattermost#14279)
 - [Database Version](mattermost/mattermost#14258) 
 - [Count of Guests](mattermost/mattermost#14257) 
 - [Experimental Audit Log config settings](mattermost/mattermost#14282)
 - [Adding the Rudder Endpoint](mattermost/mattermost#14151)

* Update telemetry.rst

* v5.23 Changelog (#3538)

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Update release-lifecycle.rst

* Update source/administration/changelog.md

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/changelog.md

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update changelog.md

* Update important-upgrade-notes.rst

Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* updated to reflect new diagnostics frequency (#3601)

* updated to reflect new diagnostics frequency

reflecting changes in mattermost/mattermost#14374

* Update telemetry.rst

* Update source/administration/telemetry.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/telemetry.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/telemetry.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/telemetry.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/telemetry.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Applying suggestions

Co-authored-by: Amy Blais <amy_blais@hotmail.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* added EnableOpenTracing to telemetry (#3534)

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update version-archive.rst (#3620)

* Update GitLab Omnibus "mattermost" command (#3611)

GitLab's way of calling mattermost has changed and the previous one mentioned here will not work. See https://docs.gitlab.com/omnibus/gitlab-mattermost/#mattermost-command-line-tools-cli

* Add (optional) pgpass steps to postgres installation in docs #3483 (#3603)

* Add (optional) pgpass steps to postgres installation in docs #3483

This part of docs was updated to add pgpass steps to Postgres installation in docs

* Update source/install/install-ubuntu-1604-postgresql.rst

* Update source/install/install-ubuntu-1604-postgresql.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/install/install-ubuntu-1604-postgresql.rst

Co-authored-by: Sven Hüster <sven.svelle@gmail.com>

* minor changes

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Sven Hüster <sven.svelle@gmail.com>

* Fix typos (#3623)

* Update important-upgrade-notes.rst

* Update changelog.md

* Update source/administration/changelog.md

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update changelog.md

* Update source/administration/important-upgrade-notes.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update important-upgrade-notes.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* [WIP] Broken images in inline section #3615 (#3619)

* [WIP] Broken images in inline section #3615

* update formatting-text.rst

* Update sysctl settings (#3581)

* Update sysctl settings

This is the updated list of tweaks that we are using for our load test cluster. Just the 2 initial settings are not enough to handle high load.

* Made the lower port range to be odd

* Update team-settings.rst (#3624)

* Update team-settings.rst

Formatting and minor grammar changes.

* Update source/help/settings/team-settings.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Javascript -> JavaScript (#3629)

* Update formatting-text.rst (#3631)

* Update formatting-text.rst

* Update formatting-text.rst

* Update source/help/messaging/formatting-text.rst

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Update mobile-app-deployment.rst (#3638)

Minor capitalization, punctuation, and acronym fixes.

* Add team settings to mobile feature parity faq.rst (#3641)

* Update faq.rst

* Update source/overview/faq.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* fixed typos in backup.rst file (#3636)

* fixed typos in backup.rst file

* Update source/administration/backup.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/administration/backup.rst

* Update source/administration/backup.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update mobile-faq.rst (#3637)

Minor grammar, punctuation, and style updates.

* Including documentation for radio element in interactive dialog (#3635)

* Including documentation for radio element

* Add the description about  to Elements

* Update example

* Fix type of options field

* Update source/developer/interactive-dialogs.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/developer/interactive-dialogs.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update config-settings.rst (#3632)

* Update config-settings.rst

* Update source/administration/config-settings.rst

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Update source/administration/config-settings.rst

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Update config-settings.rst

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Revert querystring from URL link in version archive but keep for download link (#3645)

The querystring is included in the filename when wget or curl is used to download the binary, which is the use case for the URL link

* Add note about unsupported versions (#3640)

* Update upgrade.rst

* Update upgrade.rst

* Update upgrade.rst

* Update changelog.md

* Update changelog.md

* Update version-archive.rst

* Update extended-support-release.rst

* Update release-lifecycle.rst

* Update extended-support-release.rst

* Update changelog.md

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Clarifying TE & E10 scope (#3453)

* Clarifying TE scope 

We need to update the SKU definitions, working with Ken in marketing, for now, adding some adjustments moving to the right direction.

* Update source/overview/product.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update configuring-notifications.rst (#3189)

* Update configuring-notifications.rst

Reviewed content based on #3187, and made some stylistic changes.

* Update source/help/getting-started/configuring-notifications.rst

* Update configuring-notifications.rst

Addresses this issue: #3187.

* Update source/help/getting-started/configuring-notifications.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update source/help/getting-started/configuring-notifications.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update source/help/getting-started/configuring-notifications.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update source/help/getting-started/configuring-notifications.rst

Co-authored-by: Amy Blais <amy_blais@hotmail.com>

* Update changelog.md (#3654)

* Update changelog.md

* Update changelog.md

* 5.23.1 docs (#3655)

* Update changelog.md

* Update version-archive.rst

* Update source/administration/changelog.md

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Update documentation-guidelines.rst (#3658)

* Update documentation-guidelines.rst

Added a note with a link to the Handbook and current Style Guide.

* Update source/process/documentation-guidelines.rst

Co-authored-by: Sebastian Faase <11317357+faase@users.noreply.github.com>

Co-authored-by: Sebastian Faase <11317357+faase@users.noreply.github.com>

* removed incorrect description of guest experience (#3648)

* removed incorrect description of guest experience

removed: `When a guest logs in for the first time they are presented with a default landing page until they are added to channels.`

* updated guest auth w/o channels

After discussion with Katie, we agreed the important piece of information to document is that guests with no channels can still authenticate, but do not have access to view any team/channel names or any other information.

* added under LDAP as well

* Update source/deployment/guest-accounts.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/guest-accounts.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Create an integrations overview page for MS tools (#3665)

* Create an integrations overview page for MS tools

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>

* Update source/deployment/microsoft-integrations.rst

Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

* Update microsoft-integrations.rst

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>

* Capitalization changes and fixes.

* Heading formatting, general formatting, extraneous spacing removed.

* Formatting changes in atom client.

* Formatting consistency, styles, spacing.

* Updates to formatting, naming, punctuation.

* Formatting, style, UI entities changes.

* commit

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: emilyhollinger <45377752+emilyhollinger@users.noreply.github.com>
Co-authored-by: Adam Clarkson <adam.clarkson@mattermost.com>
Co-authored-by: Sven Hüster <sven.svelle@gmail.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>
Co-authored-by: Eric Sethna <eric@mattermost.com>
Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com>
Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com>
Co-authored-by: Martin Kraft <martinkraft@gmail.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Tobias <T0biii@users.noreply.github.com>
Co-authored-by: Guillermo Vayá <guillermo.vaya@mattermost.com>
Co-authored-by: mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
Co-authored-by: John Thompson <45836988+johnthompson365@users.noreply.github.com>
Co-authored-by: Daniel Schalla <daniel@schalla.me>
Co-authored-by: Zach Trayner <ztrayner@users.noreply.github.com>
Co-authored-by: Ben Bodenmiller <bbodenmiller@gmail.com>
Co-authored-by: akarikuu <simon.runer@gmail.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Girish Ramakrishnan <girish@cloudron.io>
Co-authored-by: Melroy van den Berg <melroy@melroy.org>
Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
Co-authored-by: funkytwig <funkytwig@users.noreply.github.com>
Co-authored-by: JtheBAB <42135332+JtheBAB@users.noreply.github.com>
Co-authored-by: Favour Kelvin <39309699+fakela@users.noreply.github.com>
Co-authored-by: Ali Farooq <ali.farooq0@pm.me>
Co-authored-by: Sebastian Faase <11317357+faase@users.noreply.github.com>
Co-authored-by: George Goldberg <george@gberg.me>
Co-authored-by: Eli Yukelzon <reflog@gmail.com>
Co-authored-by: Psy-Q <rca@mailbox.org>
Co-authored-by: Agniva De Sarker <agnivade@yahoo.co.in>
Co-authored-by: Yusuke Nemoto <kaakaa@users.noreply.github.com>
Co-authored-by: it33 <it33@users.noreply.github.com>
Co-authored-by: Dennis Kittrell <dennis.kittrell@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reflog reflog reflog approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@josephbaylon josephbaylon josephbaylon approved these changes

Assignees

@justinegeffen justinegeffen

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Done Required documentation has been written QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process)
Projects
None yet
Milestone
v5.22.0
Development

Successfully merging this pull request may close these issues.

Unable to start if mailserver is listening but not responding
10 participants
@isacikgoz @mattermod @jasonblais @mgdelacroix @hanzei @amyblais @justinegeffen @reflog @josephbaylon @wiersgallak