Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-20970 - Unnecessarily permissive file mode in server-local file storage #13369

Merged
merged 1 commit into from Dec 11, 2019
Merged

MM-20970 - Unnecessarily permissive file mode in server-local file storage #13369

merged 1 commit into from Dec 11, 2019

Conversation

reflog
Copy link
Contributor

@reflog reflog commented Dec 11, 2019

Summary

corrected file permissions for localstore

Ticket Link

https://mattermost.atlassian.net/browse/MM-20970

@reflog reflog requested review from jupenur and a team December 11, 2019 10:02
@ghost ghost requested review from cpoile and deanwhillier and removed request for a team December 11, 2019 10:03
@reflog reflog requested review from lindy65 and a team and removed request for cpoile and deanwhillier December 11, 2019 10:03
@ghost ghost requested review from devinbinnie and imisshtml and removed request for a team December 11, 2019 10:03
@reflog reflog added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review AutoMerge Used by Mattermod to merge PR automatically CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 11, 2019
@lindy65
Copy link
Contributor

lindy65 commented Dec 11, 2019

Hi @reflog - can you help with QA testing steps for this PR please?

@reflog
Copy link
Contributor Author

reflog commented Dec 11, 2019

@lindy65 - in the Jira ticket there are steps to confirm. Basically - newly created files in ./data folder should have proper permissions, so QA here should be done server-side

lindy65
lindy65 approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok - thanks @reflog - this can be QA tested post-merge then 👍

@lindy65 lindy65 added QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Dec 11, 2019
@reflog reflog removed the request for review from imisshtml December 11, 2019 11:30
@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Dec 11, 2019
@mattermod
Copy link
Contributor

Will try to auto merge this PR

@mattermod mattermod merged commit f672eb7 into mattermost:master Dec 11, 2019
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: f672eb7

@mattermod mattermod removed the AutoMerge Used by Mattermod to merge PR automatically label Dec 11, 2019
@hanzei hanzei added this to the v5.20.0 milestone Dec 11, 2019
@amyblais amyblais modified the milestones: v5.20.0, v5.18.0 Dec 11, 2019
@amyblais
Copy link
Member

@reflog FYI this PR hasn't been cherry-picked yet.

@reflog
Copy link
Contributor Author

reflog commented Dec 12, 2019

/cherry-pick release-5.18

@mattermost-build mattermost-build mentioned this pull request Dec 12, 2019
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Dec 12, 2019
@reflog
Copy link
Contributor Author

reflog commented Dec 12, 2019

thanks @amyblais , will do it now

reflog added a commit that referenced this pull request Dec 12, 2019
@mattermost-build @reflog
Automated cherry pick of #13369 (#13377)
e340e67 

Co-authored-by: Eli Yukelzon <reflog@gmail.com>
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jupenur jupenur jupenur approved these changes

@lindy65 lindy65 lindy65 approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process)
Projects
None yet
Milestone
v5.18.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@reflog @lindy65 @mattermod @amyblais @jupenur @devinbinnie @hanzei