Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifies the interface to add search index metrics and initialises metrics first so it can be used from elasticsearch #13663

Merged
merged 2 commits into from Jan 23, 2020
Merged

Modifies the interface to add search index metrics and initialises metrics first so it can be used from elasticsearch #13663

merged 2 commits into from Jan 23, 2020

Conversation

mgdelacroix
Copy link
Member

@mgdelacroix mgdelacroix commented Jan 21, 2020 •
edited

@mgdelacroix
Modifies the interface to add search index metrics and initialises me…
5dd2a7a 
…trics first so it can be used from elasticsearch
@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a developer Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Tests/Not Needed New release tests not required labels Jan 21, 2020
ethervoid
ethervoid approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@ethervoid ethervoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/enterprise.go Show resolved Hide resolved
jespino
jespino approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Jan 23, 2020
@mgdelacroix mgdelacroix removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jan 23, 2020
@mgdelacroix mgdelacroix merged commit eb17f84 into master Jan 23, 2020
@mgdelacroix mgdelacroix deleted the search-index-metrics branch January 23, 2020 16:10
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@ethervoid ethervoid ethervoid approved these changes

Assignees

@mgdelacroix mgdelacroix

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgdelacroix @jespino @ethervoid @amyblais