MM-27887: set traceback to crash from code #15274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we set traceback level to crash, goroutines from all threads aren't printed. See: golang/go#13161. This is important because SIGQUIT traces will miss on goroutines. https://mattermost.atlassian.net/browse/MM-27887
agnivade
added
2: Dev Review
streamer45
approved these changes
Aug 17, 2020
|
golang/go#13161 mentions that after outputting the stacks it aborts when GOTRACEBACK=crash. I couldn't find any mention of that being changed. Do you know if this is still the behaviour? Ok, I see it raises SIGABRT. That will trigger core dump and exit. I guess that's the best we can hope for. |
lindalumitchell
approved these changes
Aug 17, 2020
lindalumitchell
added
4: Reviews Complete
|
This change will cause the service to crash with a coredump instead of just dumping the stack trace to console. |
amyblais
added
Changelog/Done
KrishnaSindhur
pushed a commit
to KrishnaSindhur/mattermost-server
that referenced
this pull request
Oct 10, 2020
Unless we set traceback level to crash, goroutines from all threads aren't printed. See: golang/go#13161. This is important because SIGQUIT traces will miss on goroutines. https://mattermost.atlassian.net/browse/MM-27887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we set traceback level to crash, goroutines from all threads aren't printed.
See: golang/go#13161.
This is important because SIGQUIT traces will miss on goroutines.
https://mattermost.atlassian.net/browse/MM-27887