[MM-32488] Cloud release 2021-02-10 #16838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
…bleUploads (#16611) * api4/config: return error when patching PluginSettings.EnableUploads * reflect review comments Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
- soft delete reaction by setting new field Reactions.DeleteAt to non-zero. - include new field Reactions.UpdateAt
This will be implemented via a mattermod check to make PR review suggestions. ```release-note NONE ```
* docker: prometheus and grafana for development Add prometheus and grafana docker configuration when developing with access to the enterprise repository. This simplifies the setup for developers adding new metrics or even examining events from their development server. The services are disabled by default when no enterprise source is detected. Grafana is provisioned automatically with the Prometheus datasource, as well as the canonical dashboards used with Mattermost. Furthermore, no authentication is required to access Grafana to simplify access from a development environment. The default home dashboard is customized to automatically show links to the provisioned dashboards. Dashboards can be saved, and login remains available via the default `admin/admin` credentials (which initiates a password reset), but no dashboard or system configuration is (currently) persisted if the container is destroyed. Linux requires slightly special handling (well, really it's Docker for MacOS/Windows), in that `host.docker.internal` is the canonical way to resolve the host on MacOS/Windows, but on Linux it's usually sufficient to just use `localhost`. Until docker/for-linux#264 is resolved, this PR includes code to customize the Prometheus configuration to point at the required address for the running platform. * metrics: track active jobs by type * metrics: active jobs chart * metrics: server start and job annotations * Update build/docker-compose.common.yml Co-authored-by: Claudio Costa <cstcld91@gmail.com> * prometheus: resolve docker host via 172.17.0.1 instead * skip enabling prometheus and grafana by default * handle JOB_STATUS_ERROR and JOB_STATUS_CANCELED end states * handle nil srv.metrics * lookup job to determine type for metrics * mocked unit tests for jobs * goimports lint fixes * missing license * add instance to server start tag * filter annotations by selected instance Co-authored-by: Claudio Costa <cstcld91@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
We were incorrectly setting the cache control to public when it should be rather private. https://mattermost.atlassian.net/browse/MM-31721 ```release-notes Fix Cache-Control headers to instruct that responses may only be cached on browsers. ```
```release-note Updated Go dependencies to their latest minor version ``` https://mattermost.atlassian.net/browse/MM-32048
We were allowing new password to be reset without asking for the old password. This was not advertised but was possible nevertheless through the API. Since there is already a separate API to change password, we choose to remove this functionality. https://mattermost.atlassian.net/browse/MM-32013 ```release-note The /api/v4/users/me/auth API endpoint cannot be used to change password anymore. This was a hidden feature that was not documented, but was nevertheless possible. We are just removing the hidden feature. ``` Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
As mentioned in the documentation:
> Truncate operates on the time as an absolute duration since the zero time;
it does not operate on the presentation form of the time. Thus,
Truncate(Hour) may return a time with a non-zero minute, depending on the
time's Location.
As a result, truncating for anything more than an hour is buggy and should
not be done. The correct way is to construct the date object using the
day, month and year.
https://mattermost.atlassian.net/browse/MM-31353
```release-notes
Fixed a bug in product notices where a date constraint might
fail to match, and would lead to the notice not being fetched
```
…ds as unread. (#16757) * mark thread as read query fix * test fix * lint
* streamline serialization auto-gen
Automatic Merge
Adds the check for #16674 in the Makefile ```release-note NONE ```
* Translated using Weblate (Swedish) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (2122 of 2122 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (2121 of 2121 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/sv/ * Translated using Weblate (Dutch) Currently translated at 100.0% (2124 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Dutch) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Dutch) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ * Translated using Weblate (Turkish) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/bg/ Translated using Weblate (Bulgarian) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/bg/ * Translated using Weblate (Japanese) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ja/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ * Translated using Weblate (Romanian) Currently translated at 100.0% (2124 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ Translated using Weblate (Romanian) Currently translated at 100.0% (2123 of 2123 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/ * Translated using Weblate (Spanish) Currently translated at 96.7% (2054 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ * Translated using Weblate (Turkish) Currently translated at 99.9% (2123 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/ Translated using Weblate (Dutch) Currently translated at 100.0% (2124 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/ Translated using Weblate (Spanish) Currently translated at 96.7% (2054 of 2124 strings) Translation: mattermost-languages-shipped/mattermost-server Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/ Co-authored-by: majo <martinjohnson@bahnhof.se> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> Co-authored-by: kaakaa <stooner.hoe@gmail.com> Co-authored-by: Viorel-Cosmin Miron <cosmin@uhlhost.net> Co-authored-by: Elias Nahum <elias@mattermost.com> Co-authored-by: Elisabeth Kulzer <elisabeth.kulzer@mattermost.com>
…15953) Co-authored-by: Cam Graff <cameron@woodridgesoftware.com>
* use sync.pool for session * added back to sync pool * reverted change * added a new line * added back session object * added back session object * added back session object * revert * refactored into function * added the session object back into the pool * work in progress * work in progress * work in progress * code review comments Co-authored-by: Arjuna Marambe <arjunam@buildxact.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Update config.go * Update telemetry.go * Update store and store test * Update settings.go * use new error code * Trigger CI Co-authored-by: Haardik Dharma <dharmahaardik08@gmail.com>
* MM-31993: Add flag to disable gossip compression Load tests have shown that our workload is not very suitable to LZW compression. And in fact, compressing leads to more network bandwidth than less. So we are spending more CPU cycles, and creating more traffic, leading to a lose-lose situation. We add a flag to control this behavior. Ideally, this should not be a flag in the first place, since there is never a need to enable this because clearly there is no benefit. But to keep our community servers working, we need to be able to configure this. https://mattermost.atlassian.net/browse/MM-31993 ```release-notes Add a flag to disable compression in the Gossip protocol. By default the value of the flag is false, which is not the existing default. Therefore, this will cause incompatibility issues during upgrade where servers of different versions are part of the same cluster. It is recommended to completely shutdown a cluster, and then do an upgrade. ``` * flip flag to true * Trigger CI Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Automatic Merge
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
The Makefile has a command to validate Go version. We bump it up to require 1.15.
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
mm-cloud-bot
added
the
release-note
Signed-off-by: Mario de Frutos <mario@defrutos.org>
Signed-off-by: Mario de Frutos <mario@defrutos.org>
jwilander
approved these changes
Feb 1, 2021
marianunez
approved these changes
Feb 1, 2021
store/sqlstore/upgrade.go
Outdated
| sqlStore.AlterColumnTypeIfExists("Posts", "FileIds", "text", "varchar(300)") | ||
| sqlStore.CreateColumnIfNotExistsNoDefault("Channels", "Shared", "tinyint(1)", "boolean") | ||
| sqlStore.CreateColumnIfNotExists("ThreadMemberships", "UnreadMentions", "bigint", "bigint", "0") | ||
| sqlStore.CreateColumnIfNotExistsNoDefault("Channels", "Shared", "tinyint(1)", "boolean") |
There was a problem hiding this comment.
Not sure if this intended but this seems repeated from L1013
There was a problem hiding this comment.
Yep good catch! Done
Signed-off-by: Mario de Frutos <mario@defrutos.org>
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cloud release branch for 2021-02-10
Ticket Link
The cloud release branch for 2021-02-10
Release Note