Enable the errorAssertions govet check for mattermost-server code #17346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions-govet-check
…tions-govet-check
…tions-govet-check
…tions-govet-check
…tions-govet-check
…tions-govet-check
…tions-govet-check
…tions-govet-check
mm-cloud-bot
added
the
release-note-none
agnivade
approved these changes
Apr 12, 2021
|
/update-branch |
jespino
added
4: Reviews Complete
mgdelacroix
pushed a commit
that referenced
this pull request
Apr 18, 2021
…7346) * Enable the errorAssertions govet check for mattermost-server code * Removing unnecesary change * Fixing some tests * Fixing tests * Fixing more after merge * Fixing new offending entries * Fixing small vet checks * Fixing new cases detected by govet * Fixing remote_cluster_test errors * Fixing assertion Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable the errorAssertions govet check for mattermost-server code (This is submitting again the already reviewed PR: #17091)
Ticket Link
https://mattermost.atlassian.net/browse/MM-34642
Release Note