Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-39448] Explicitly handle values in audit type conversion #18768

Merged
merged 1 commit into from Oct 20, 2021
Merged

[MM-39448] Explicitly handle values in audit type conversion #18768

merged 1 commit into from Oct 20, 2021

Conversation

streamer45
Copy link
Contributor

Summary

Adding explicit support for model structs values during audit type conversion.

Ticket Link

https://mattermost.atlassian.net/browse/MM-39448

Release Note

NONE

@streamer45 streamer45 added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 20, 2021
@streamer45 streamer45 self-assigned this Oct 20, 2021
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 20, 2021
srkgupta
srkgupta approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @streamer45. Tested and the changes LGTM and is working fine now.

wiggin77
wiggin77 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a developer labels Oct 20, 2021
@amyblais amyblais added this to the v6.0.0 milestone Oct 20, 2021
@amyblais
Copy link
Member

@streamer45 Does this need QA review?

@srkgupta
Copy link
Contributor

@streamer45 Does this need QA review?

@amyblais I have tested this and the audit log is working fine

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 20, 2021
@streamer45 streamer45 merged commit 01f2b20 into master Oct 20, 2021
@streamer45 streamer45 deleted the MM-39448 branch October 20, 2021 12:52
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build mentioned this pull request Oct 20, 2021
Merged
mattermost-build pushed a commit to mattermost-build/mattermost that referenced this pull request Oct 20, 2021
@streamer45 @mattermost-build
Explicitly handle values in audit type conversion (mattermost#18768)
9f8bebd 
(cherry picked from commit 01f2b20)
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 20, 2021
@streamer45
Copy link
Contributor Author

/cherry-pick cloud

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost that referenced this pull request Oct 20, 2021
@streamer45 @mattermost-build
Explicitly handle values in audit type conversion (mattermost#18768)
fc2e9da 
(cherry picked from commit 01f2b20)
@mattermost-build mattermost-build mentioned this pull request Oct 20, 2021
Merged
streamer45 added a commit that referenced this pull request Oct 20, 2021
@mattermost-build @streamer45
Explicitly handle values in audit type conversion (#18768) (#18770)
9715a94 
(cherry picked from commit 01f2b20)

Co-authored-by: Claudio Costa <cstcld91@gmail.com>
streamer45 added a commit that referenced this pull request Oct 20, 2021
@mattermost-build @streamer45
Explicitly handle values in audit type conversion (#18768) (#18771)
8dc3c4b 
(cherry picked from commit 01f2b20)

Co-authored-by: Claudio Costa <cstcld91@gmail.com>
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Oct 20, 2021
FreedomBen pushed a commit to FreedomBen/mattermost-server that referenced this pull request Jun 14, 2022
@streamer45 @FreedomBen
Explicitly handle values in audit type conversion (mattermost#18768)
166164f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@agnivade agnivade agnivade approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees

@streamer45 streamer45

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@streamer45 @amyblais @srkgupta @mattermod @agnivade @wiggin77 @mm-cloud-bot