New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-46644] Auto respond message #20900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a unit test
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the validation is in place only while creating a user & importing a user. Can we also add this check in other places, for example:
func (us SqlUserStore) Update(user *model.User, trustedUpdateData bool) (*model.UserUpdate, error) {
func (us SqlUserStore)
(userID string, props map[string]string) error {
@srkgupta Validation is already added in the funcs, you have mentioned. @ashishbhate Added tests and logging |
Additional changes requested. Please check the channel for more details. |
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
/e2e-test |
Successfully triggered e2e testing! |
@srkgupta @ashishbhate It's up for review. |
Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour. |
Trying to auto merge this PR. |
Pull Request successfully merged |
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
Test server destroyed |
/cherry-pick cloud |
Cherry pick is scheduled. |
Automatic Merge (cherry picked from commit 6e9b808)
/cherry-pick release-7.3 |
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
Summary
Fix auto-respond message
Ticket Link
JIRA - https://mattermost.atlassian.net/browse/MM-46644
Release Note