Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore link-local addresses in cluster advertisement #9223

Merged
merged 1 commit into from Aug 9, 2018

Conversation

MerlinDMC
Copy link
Contributor

Summary

Ignore link-local class addresses when selecting the IP address to advertise to the cluster.

Ticket Link

Requested by Jason Blais via e-mail

Checklist

  • Added or updated unit tests (required for all new features)
  • Added API documentation (required for all new APIs)
  • All new/modified APIs include changes to the drivers
  • Has enterprise changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, upgrade, etc.)

@mattermod
Copy link
Contributor

Thanks @MerlinDMC for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@jasonblais jasonblais added 2: Dev Review Requires review by a developer Setup Old Test Server Triggers the creation of a test server labels Aug 7, 2018
@jasonblais
Copy link
Contributor

Thanks @MerlinDMC! Have reached out to devs for review.

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Aug 7, 2018
@mattermost mattermost deleted a comment from mattermod Aug 7, 2018
@mattermost mattermost deleted a comment from mattermod Aug 7, 2018
@mattermost mattermost deleted a comment from mattermod Aug 7, 2018
@jasonblais
Copy link
Contributor

jasonblais commented Aug 7, 2018

@MerlinDMC I sent you an email, but including here too for visibility: https://releases.mattermost.com/mattermost-platform-pr/9223/mattermost-enterprise-linux-amd64.tar.gz can be used to test the changes

@jasonblais
Copy link
Contributor

Verified tested, @crspeller this is ready to merge.

@crspeller crspeller merged commit 0bbabd1 into mattermost:master Aug 9, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed New release tests not required label Aug 11, 2018
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants