MM-11582 Fail plugin activation if no web app and server component #9438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it possible to add tests or this is too hard to check? |
|
Unfortunately the plugin environment isn't tested directly right now and adding/setting up those tests as part of this ticket seemed out of scope We should probably add some direct unit tests for this code but I'd say that's a separate larger mana ticket |
crspeller
approved these changes
Sep 21, 2018
lindy65
added
Tests/Not Needed
amyblais
added
Changelog/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fail plugin activation if no web app and server component.
Ticket Link
https://mattermost.atlassian.net/browse/MM-11582