Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CustomServiceTermsEnabled to the correct table in diagnostics #9521

Merged
merged 2 commits into from Oct 4, 2018

Conversation

jasonblais
Copy link
Contributor

PR that added the setting is at #9450

@jasonblais jasonblais added the 2: Dev Review Requires review by a developer label Oct 2, 2018
@jasonblais jasonblais added this to the v5.4.0 milestone Oct 2, 2018
@grundleborg grundleborg added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Oct 3, 2018
@jasonblais
Copy link
Contributor Author

@cpanato Ready to merge and cherry-pick to v5.4

@cpanato cpanato merged commit c4a52a4 into master Oct 4, 2018
@cpanato cpanato deleted the jasonblais-patch-1 branch October 4, 2018 11:43
cpanato pushed a commit that referenced this pull request Oct 4, 2018
…9521)

* Move CustomServiceTermsEnabled to the correct table in diagnostics

* Fix style error
@cpanato
Copy link
Contributor

cpanato commented Oct 4, 2018

cherry-pick c4a52a4 to release 5.4 branch

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 4, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed New release tests not required label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants