Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all user lists to be infinite scroll. #11241

Open
esethna opened this issue Jun 17, 2019 · 11 comments
Open

Change all user lists to be infinite scroll. #11241

esethna opened this issue Jun 17, 2019 · 11 comments

Comments

@esethna
Copy link
Contributor

esethna commented Jun 17, 2019

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.


Notes: Jira ticket

Change all user lists (More... DM list and manage/view team members) to be infinite scroll using a similar loading indicator as the post list infinite scroll:

!screenshot-1.png|thumbnail!

Threshold will be 30 per list and load more when the scroll passes the threshold.

Current paging experience:
image

@sapnasivakumar
Copy link
Contributor

@esethna I would like to work on this ticket, Can you please assign it to me

@jespino
Copy link
Member

jespino commented Jun 20, 2019

Sure @sapnasivakumar, work on it, I've removed the Up For grabs tag :) Let us know if you need any help.

@hanzei
Copy link
Contributor

hanzei commented Sep 11, 2019

@sapnasivakumar You want to know, if you are still working on this?

@sapnasivakumar
Copy link
Contributor

@hanzei Please add the up for grabs tag as I'm not able to work on it currently
Thank You

@hanzei
Copy link
Contributor

hanzei commented Sep 11, 2019

Thanks for the heads up 👍

@fmunshi
Copy link
Contributor

fmunshi commented Nov 15, 2019

This seems like a good first ticket for me, could you assign it to me?

@hanzei
Copy link
Contributor

hanzei commented Nov 18, 2019

Sure, thanks for taking a shot. Let me know if you have any questions or stubble across any issues @fm2munsh

@fmunshi
Copy link
Contributor

fmunshi commented Nov 21, 2019

@hanzei I opened a PR yesterday - not sure if you got pinged but would be grateful for a review before it gets too old since it touches a lot of files

@hanzei
Copy link
Contributor

hanzei commented Nov 22, 2019

Hey @fm2munsh,

Thanks for the PR. I will request reviews ASAP. Please be aware that there is currently a Mattermost Hackathon going on. I assume it will take until next week until someone reviews your PR.

@julmondragon
Copy link
Contributor

Hi there! I'd like to work on this issue, could you please assign it to me?

@calebroseland
Copy link
Member

All yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants