Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine behavior for adding new lines in messages #12316

Open
mattermod opened this issue Sep 20, 2019 · 13 comments
Open

Refine behavior for adding new lines in messages #12316

mattermod opened this issue Sep 20, 2019 · 13 comments

Comments

@mattermod
Copy link
Contributor

mattermod commented Sep 20, 2019

This applies applies to both Mac & Windows

When Advanced > send messages on CTRL-ENTER is set to "Off", allow the following keys to insert new lines:

  1. Shift-ENTER (Already implemented)
  2. CTRL-ENTER
  3. ALT-ENTER (Already implemented)

______

When Advanced > send messages on CTRL-ENTER is set to "On for all messages", allow the following keys to insert new lines:

  1. ENTER (Already implemented)
  2. Shift-ENTER (Already implemented)
  3. ALT-ENTER (Already implemented)

______

When Advanced > send messages on CTRL-ENTER is set to "On only for code blocks starting with ```",

  1. Allow the following keys to insert new lines inside a code block:
  1. ENTER (Already implemented)
  2. Shift-ENTER (Already implemented)
  3. ALT-ENTER (Already implemented)
  1. Allow the following keys to insert new lines when not in a code block
  1. Shift-ENTER (Already implemented)
  2. CTRL-ENTER
  3. ALT-ENTER (Already implemented)

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-9343

@CSBatchelor
Copy link

I can do this one.

@hanzei
Copy link
Contributor

hanzei commented Oct 17, 2019

Thanks for working on this @CSBatchelor 👍

@jasonblais
Copy link
Contributor

Hey @CSBatchelor how are things going? Any questions so far? :)

@CSBatchelor
Copy link

Hi @jasonblais I haven't started on this yet, I just started a new full-time Software Engineer job and I forgot! I still want to do this though, I should be able to start on it within the next few days.

@jasonblais
Copy link
Contributor

Great, thanks @CSBatchelor, and congrats on your new job! 🎉

@CSBatchelor CSBatchelor removed their assignment Mar 27, 2020
@CSBatchelor
Copy link

Sorry I never got around to this, I unassigned myself so this issue can be picked up by someone else. I hope to work with Mattermost again in the near future!

@hanzei
Copy link
Contributor

hanzei commented Mar 27, 2020

Thanks for the heads up @CSBatchelor 👍

@M-ZubairAhmed
Copy link
Member

let me work on this, this is backend of frontend ticket as @deanwhillier puts it :P

@hanzei
Copy link
Contributor

hanzei commented Jul 23, 2020

Awesome @M-ZubairAhmed, looking forward to your PR!

@esethna
Copy link
Contributor

esethna commented May 11, 2021

@M-ZubairAhmed how's this going? :)

@cinlloc
Copy link
Contributor

cinlloc commented Oct 2, 2022

Hi, I would like to work on this ✋

@cinlloc
Copy link
Contributor

cinlloc commented Oct 27, 2022

Hi, after having read the code it seems a bit complex for me at this time, I give up for now.

@mmospanenko
Copy link

mmospanenko commented Feb 23, 2024

[Boards] Jump over words (cmd+left/right) do not work too. Very annoying thing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests