New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate allChannelMembersNotifyPropsForChannelCache cache from store/sqlstore/channel_store.go to the new store/localcachelayer #13102
Comments
I'd lieke to take up this issue :) |
Also I can grab it, if @evalevanto change his mind :) |
Hey @igomonov88 looks like this is up for grabs for you. Let us know if you're still interested in working on this one? :) |
Hello @jasonblais, yes I’m interesting in it and currently start working on it. Hope what I will make pull request in Thursday. |
Sounds great, thanks @igomonov88 for the quick reply 👍 |
hi 👋 can I pick this up |
@arjunagl go for it! :D |
@jasonblais I have created a draft PR, could you please have a quick run though and check if its on track to what you expect. |
Excellent, thank you! Queued it for review @arjunagl |
Mattermost is migrating the old way to implement caches moving them behind a transparent layer on to of the store and we're looking for contributors to help with that effort. This Help Wanted issue is to migrate the
allChannelMembersNotifyPropsForChannelCache
cache variable in thestore/sqlstore/channel_store.go
file to thestore/localcachelayer
.The expected way to implement it is, go to the
store/sqlstore/channel_store.go
file get all the code that is related to the cache variableallChannelMembersNotifyPropsForChannelCache
and move it to thestore/localcachelayer
Besides is expected to generate tests mocking the database store, and checking that the cache behavior is the expected one.
Example: #13045
If you have any question, you can contact with
jesus.espino
at https://community.mattermost.comIf you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-20103
The text was updated successfully, but these errors were encountered: