Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming webhooks notify users and we can't prevent it #13881

Open
mksondej opened this issue Feb 13, 2020 · 5 comments
Open

Incoming webhooks notify users and we can't prevent it #13881

mksondej opened this issue Feb 13, 2020 · 5 comments
Labels
Bug Report/Open Bug report/issue

Comments

@mksondej
Copy link

Summary

Incoming webhooks notify users and we can't prevent it.

Steps to reproduce

  1. Have a software with its own accounts and comment system + webhooks to notfiy slack/mattermost (e.g Azure DevOps).
  2. Write a comment with @FirstName LastName to notify somebody in said software.
  3. When mattermost picks up that event and writes a message to a channel, it sees @Something in the contents and notifies user with that login (see that it ignores what comes after space). This way it often notifies the wrong user.

Expected behavior

Webhooks don't notify users automatically unless enabled. It would be useful to have a config for that when creating the webhook. If checked it would escape message contents.

Observed behavior (that appears unintentional)

Webhooks assume all systems have the same logins and always notify users.

@amyblais
Copy link
Member

@Amonith What Mattermost version are you on?

@mksondej
Copy link
Author

@amyblais 5.19.0

@amyblais
Copy link
Member

Do you mean that it notifies users who have the same first name and not the one user with the full username?

@mksondej
Copy link
Author

mksondej commented Feb 14, 2020

@amyblais Well pretty much. Exact scenario (names changed):
On MM we have users: "Marylin Manson" with login @Marylin, and "Marylin Monroe" with login @Monroe.
Azure DevOps (and probably a lot of other software) uses full names for notifications (to be exact it automatically changes @login to full names), so for example users can write a comment with "Hey @Marylin Monroe, can you look at this?". When that comment is posted to Mattermost by an automatic incoming webhook, it notifies the user @Marylin, so the wrong one.

In my opinion matching by full name wouldn't be a reasonable solution either. It'd be better to allow disabling automatic user mentions altogether when setting up the webhook for a channel, because we can't assume that other software we're integrating with has even the same users (@lorem in MM and @lorem from that software can be 2 different people).

@amyblais
Copy link
Member

Thanks, opened a ticket: https://mattermost.atlassian.net/browse/MM-22611.

@amyblais amyblais added the Bug Report/Open Bug report/issue label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report/Open Bug report/issue
Projects
None yet
Development

No branches or pull requests

2 participants