Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating Incoming Webhooks don't allow Archived Channels to be selected as a channel for the webhook #14199

Open
arjitc opened this issue Mar 31, 2020 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@arjitc
Copy link
Contributor

arjitc commented Mar 31, 2020

Summary

When creating Incoming Webhooks don't allow Archived Channels to be selected as a channel for the webhook

Steps to reproduce

Integrations --> Incoming Webhooks --> Channel

Expected behavior

When adding a Incoming Webhook it should not allow selecting (or should not display) archived channels, servers with many archived channels make it difficult to select the correct channel to setup the web-hook to.

Observed behavior (that appears unintentional)

Both arhcived and active channels appear in the channel selection dropdown menu

Possible fixes

Don't display archived channels in the dropdown when selecting the channel to setup the web-hook to

@aaronrothschild
Copy link
Contributor

aaronrothschild commented Mar 31, 2020

Question for a developer:

  • When a channel is not yet archived and an incoming webhook is setup for that channel, is the "Incoming Webhook" deleted/removed/unconfigured - or does it remain as is...so that when/if the channel is unarchived, the incoming webhook will continue to work as before it was archived?
  • If the chanel is archived and a webhook is posted to the "Incoming Webhook" ... does the post return an error, or is the message added to the archived channel?
  • If we changed this behavior...it could affect customers. For example - they may expect the webhook to continue catching the webhook - even for archived channels (ie: notifications continue to flow in).
  • If someone accidentally archives a channel - then unarchives it, it would be unfortunate if the incoming webhooks had to be re-configured for that channel.

Question: is there a use case for pointing webhooks to an archived channel? (ie: Incident Response channels may continue to get data pushed to them even after the issue is closed/done for example). If so, then we may need to make a uX option for hiding/displaying archived channels so they don't crowd the selector.

@amyblais amyblais added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants