Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of the multi-word text arguments without quotes #14740

Open
iomodo opened this issue Jun 3, 2020 · 8 comments
Open

Add support of the multi-word text arguments without quotes #14740

iomodo opened this issue Jun 3, 2020 · 8 comments
Assignees
Labels
Area/Toolkit Plugins and integrations framework Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted PR Exists Tech/Go Server

Comments

@iomodo
Copy link
Contributor

iomodo commented Jun 3, 2020

To input multi-word text argument in the slash command autocomplete we use quotes. Here is the code how we parse it.
But if model.AutocompleteArgTypeText is the last argument of a command tree there is no need to have quotes for a multi-word input.
Change the code to support multi-word input without quotes for the last argument of the command.

Example: /agenda queue "message with quotes" vs /agenda queue message without quotes

Changes should be done only on a server.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-25545

@iomodo iomodo added Difficulty/2:Medium Medium ticket Tech/Go Server Up For Grabs Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Area/Toolkit Plugins and integrations framework labels Jun 3, 2020
@mukulrawat1986
Copy link
Contributor

Hi, I would like to work on this.

@reflog
Copy link
Contributor

reflog commented Jul 2, 2020

@mukulrawat1986 - are you still working on this or can we reassign? cc @iomodo

@mukulrawat1986
Copy link
Contributor

Yea, I am still working on this.

@Shubhamchinda
Copy link

I'd like to take this.

@mukulrawat1986
Copy link
Contributor

@reflog Please reassign this to @Shubhamchinda

@jfrerich
Copy link
Contributor

This issue appears stale and I’m adding the Up For Grabs label. If work is ongoing, please remove the label. If there is an existing PR, please also link it to the issue. Thanks!

@Mavintyre
Copy link

Still learning Go, but I'd like to take a swing at this.

@Mavintyre
Copy link

Read all the documentation for contributions, but if I missed anything, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Toolkit Plugins and integrations framework Difficulty/2:Medium Medium ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted PR Exists Tech/Go Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants