Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render custom emoji in custom branding text #15929

Open
mattermod opened this issue Oct 12, 2020 · 5 comments
Open

Render custom emoji in custom branding text #15929

mattermod opened this issue Oct 12, 2020 · 5 comments

Comments

@mattermod
Copy link
Contributor

  1. Create a custom emoji for "yay"
  2. Go to System Console > Customization, enable custom branding and enter the following as the custom branding text

:yay:

Observed: Custom emoji doesn't render

Expected: Custom emoji renders.

NOTE: Also applies for terms of service feature.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-12657

@cinlloc
Copy link
Contributor

cinlloc commented Oct 12, 2020

✋ I would like to work on this one.

@cinlloc
Copy link
Contributor

cinlloc commented Oct 14, 2020

I found that entities.emojis.customEmoji map is empty in login screen state. It appears that markdown component needs this map to render custom emojis properly. I tried to initiate the map using emoji.ts#getCustomEmojis in root.jsx but unfortunately it doesn't work (authentication error in promise). Do you think I'm on the good way or should I change the approach?

@cinlloc
Copy link
Contributor

cinlloc commented Oct 19, 2020

Seems there is an internal debate about security issues with this bug (cf. https://mattermost.atlassian.net/browse/MM-12657). Could you kindly double-check that the feature is wanted?

@cinlloc cinlloc removed their assignment Nov 18, 2020
@wget
Copy link
Collaborator

wget commented Mar 22, 2021

Same applies for other locations on the interface like the display name of a channel.
https://twitter.com/Arawa_fr/status/1373924759147253760

Some companies like Arawa would like to add their own emojis for the projects their are working in. Having a distinct emoji could have helped notice easily the channel and win a bunch of seconds each day.

@wget
Copy link
Collaborator

wget commented Mar 22, 2021

I'm assigning this to me for my "list of easyhacks to work when time allows" 👼

@wget wget self-assigned this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants