Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocomplete for Display Name when searching in a channel, #16242

Open
mattermod opened this issue Nov 9, 2020 · 12 comments
Open

Support autocomplete for Display Name when searching in a channel, #16242

mattermod opened this issue Nov 9, 2020 · 12 comments

Comments

@mattermod
Copy link
Contributor

We should support autocomplete for Channel and user display names with spaces in the search box.

Observed:
If you type "in: Ask Anything", the space character hides the autocomplete

Expected
We need to support spaces for in: and from: search to support this, similar to the way we support spaces for autocomplete in a channel when @ is typed


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-23267

@esethna esethna changed the title Global Search: For Searching in a channel, support autocomplete for Display Name Support autocomplete for Display Name when searching in a channel, Nov 9, 2020
@shFrank
Copy link

shFrank commented Nov 22, 2020

Hi can I claim this?

@shFrank
Copy link

shFrank commented Nov 24, 2020

Hi,
I'm trying to set up my web app but encountered some issues. Currently, I cannot pass the make test nor do make run.

Below are my terminal result, my node and npm versions, and the error log.

Screen Shot 2020-11-24 at 5 19 18 PM
Screen Shot 2020-11-24 at 5 19 34 PM

I checked the documentation at https://developers.mattermost.com/contribute/webapp/unit-testing/#4-getting-jest-assertion-failures-at-lines-containing-expect-tobecalledwith-expect-tohavebeennthcalledwith-or-expect-tohavebeencalledtimes-when-running-make-test
but I did not find a solution there.

@shFrank
Copy link

shFrank commented Dec 12, 2020

@amyblais Hi, I have located the cause of the problem.
At search_channel_provider.jsx Line 37, the regex /\b(?:in|channel):\s(\S)$/i** is causing parsing error. When the input contains space (eg. "Town Squ"), the regex will parse the string to null.
However, I'm not that proficient with regex, could you offer me some help about why it would parse the string into null?

@amyblais
Copy link
Member

@esethna ^

@shFrank
Copy link

shFrank commented Dec 14, 2020

@esethna Hi, could you help me out?

@esethna
Copy link
Contributor

esethna commented Dec 14, 2020

Hi @shFrank, feel free to ask in our contributors channel and/or peer-to-peer help as a starting point?

https://community.mattermost.com/core/channels/peer-to-peer-help
https://community.mattermost.com/core/channels/tickets

cc// @amyblais

@hmhealey
Copy link
Member

hmhealey commented Feb 2, 2021

Reopening this for anyone else who'd like to work on it. I've also bumped the difficulty up since we found some things around display names that will require some extra tweaks to the Provider object that returns the autocomplete results.

@Hanaffi
Copy link

Hanaffi commented Feb 2, 2021

@hmhealey Can you assign it to me?

@SBagaria2710
Copy link

I don't think this feature was completed 😅
If it is still pending, I'd like to take a look 😄

@esethna
Copy link
Contributor

esethna commented Sep 23, 2021

@SBagaria2710 it's all yours

@Willyfrog
Copy link
Contributor

@SBagaria2710 are you still working on this one?

@SBagaria2710
Copy link

No, I am not. Please, assign it to someone else - @Willyfrog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants