Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom sidecars #16876

Open
Philmod opened this issue Feb 5, 2021 · 18 comments
Open

Support for custom sidecars #16876

Philmod opened this issue Feb 5, 2021 · 18 comments
Assignees
Labels
Area/Mattermost Operator kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Philmod
Copy link

Philmod commented Feb 5, 2021

Summary

In order to use Cloud SQL for Mattermost, in a secure way, they recommend adding a proxy as a sidecar.
https://cloud.google.com/sql/docs/mysql/connect-kubernetes-engine#running_the_proxy_as_a_sidecar

Unfortunately, it's not possible today as the Operator rewrites the whole deployment as soon as it's modified.

@balan2010
Copy link

Hi! I would like to work on this

@Szymongib
Copy link
Contributor

Hi @balan2010, sure feel free to take it!
If you need any support let us know here or on Mattermost community server.

@balan2010
Copy link

Thanks @Szymongib sure will get in touch in community channel if I need any support :-)

@balan2010
Copy link

@Szymongib would you be able to assign this to me. I don't have permission to do so

@vineelyalamarthy
Copy link

@jwilander @Philmod @balan2010 is there help needed on MatterMost operator.

@Philmod
Copy link
Author

Philmod commented Jun 2, 2021

@balan2010 Any update on this? Thanks for picking it up!

@vineelyalamarthy
Copy link

Is any one already working on this? I would like to contribute. @Philmod @balan2010

@balan2010
Copy link

@vineelyalamarthy I won't be able to work on this for atleast couple of months. So feel free to work on it

@vineelyalamarthy
Copy link

/assign

@jasonblais
Copy link
Contributor

@vineelyalamarthy I have assigned the issue to you

@vineelyalamarthy
Copy link

vineelyalamarthy commented Aug 17, 2021

@jasonblais is there a grooming or vetting process that happens before a posted issue becomes a story .
Also do we want to support Cloud SQL for Mattermost as asked by @Philmod.

@jasonblais
Copy link
Contributor

Yes, we have a process to review tickets before turning them to help wanted: https://handbook.mattermost.com/contributors/contributors/ways-to-contribute/help-wanted

@Szymongib I would defer to you regarding the Cloud SQL question?

@Szymongib
Copy link
Contributor

I think we would like to have a more generic mechanism that allows adding sidecars to pods running Mattermost and Cloud SQL would be just one option.

@Philmod
Copy link
Author

Philmod commented Jul 18, 2022

Any update here?

@Philmod
Copy link
Author

Philmod commented Dec 22, 2023

Hi! Any status here?

@gabrieljackson
Copy link
Contributor

Hey @Philmod, I was just shown this request and think we can add support for custom sidecars fairly easily. I will give you an update in the next few days.

@gabrieljackson
Copy link
Contributor

@Philmod the functionality to add custom sidecars to the Mattermost deployment was merged. Note that this is the original implementation of sidecars and not the new feature-gated one which is in alpha, although we may migrate to that in the future once it stabilizes more.

This will be included in our next operator release which will be made available after we complete testing.

@amyblais amyblais added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2024
@Philmod
Copy link
Author

Philmod commented Mar 29, 2024

Thanks @gabrieljackson! Is there any documentation on how to configure such a sidecar, maybe from an installation.mattermost.com kubernetes config?

Right now the doc explains how to set up the SQL connection secret for mattermost to connect, but would you know how we could adapt that if we wanted to use the Cloud SQL Auth Proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Mattermost Operator kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

9 participants