Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp/Desktop: Update loading indicator spinners #21190

Open
mattermod opened this issue Oct 3, 2022 · 10 comments
Open

Webapp/Desktop: Update loading indicator spinners #21190

mattermod opened this issue Oct 3, 2022 · 10 comments
Assignees

Comments

@mattermod
Copy link
Contributor

mattermod commented Oct 3, 2022

The Initial Desktop loading animation was done as part of the MM-22810, but the small spinners were not completed. This ticket is to queue up that work.

Figma

https://www.figma.com/file/uSyFbf9UrSEfWWW3dLbajL/?node-id=0%3A1

Update it to a spinning circle similar to material design:

image

Applies to:

  • Channel loading ...
  • Search loading
  • Image loading
  • Button loading/saving states
  • Members modals
  • Channel switcher
  • Autocomplete (channels, mentions)
  • Infinite scroll (post list, members lists, search results)
  • Team loading

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-32256

@ghost
Copy link

ghost commented Oct 4, 2022

Hi @mattermod, the image that are attached are not visible and the Figma link seems to be invalid.
I hope you will fix these and let me know when they are done , so that I can start working on this issue!

@esethna
Copy link
Contributor

esethna commented Oct 4, 2022

@VoidCupboard the figma link should be working now! Check out the JIRA ticket for the images and attachments: https://mattermost.atlassian.net/browse/MM-32256

@esethna esethna assigned ghost Oct 4, 2022
@ghost
Copy link

ghost commented Oct 4, 2022

Thanks for the updated figma link @esethna !

@Willyfrog
Copy link
Contributor

added the image into the issue, let us know if there is any other thing missing or if you have any questions!

@ghost
Copy link

ghost commented Oct 4, 2022

Thanks a bunch, @Willyfrog :D. I don't think there is anything else that is missing

@ghost
Copy link

ghost commented Oct 7, 2022

I just wanted to confirm, I need to replace the loading icon (Shown in the image) with the new Figma link across all the pages where it is mentioned.
mattermost

@esethna
Copy link
Contributor

esethna commented Oct 7, 2022

Correct @VoidCupboard!

@ghost
Copy link

ghost commented Oct 8, 2022

Thanks for the confirmation :)

@qianzhong516
Copy link

Is this one still available for pickup?

@codejagaban
Copy link
Contributor

Hi @amyblais is this still up for grabs?
I could work on it this weekend

@amyblais amyblais assigned codejagaban and unassigned qianzhong516 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants